Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reusable workflows to correct location #2334

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

AlanGreene
Copy link
Member

Changes

Attempting to use the reusable workflows as they were results in the following error from GitHub Actions:

Invalid workflow file: .github/workflows/slash.yml#L8
invalid value workflow reference: references to workflows must be rooted in '.github/workflows'

Move the files to the correct location to resolve this error.

/cc @afrittoli
/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Attempting to use the reusable workflows as they were results in the
following error from GitHub Actions:
```
Invalid workflow file: .github/workflows/slash.yml#L8
invalid value workflow reference: references to workflows must be rooted in '.github/workflows'
```

Move the files to the correct location to resolve this error.
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Dec 17, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2024
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@afrittoli
Copy link
Member

Thanks @AlanGreene, I guess I implemented an hybrid between a reusable workflow and a composite action which wasn't neither one nor the other 🤦

I think reusable workflow is the right format for these, thanks for trying them out.

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 07a33d1 into tektoncd:main Dec 18, 2024
4 checks passed
@AlanGreene AlanGreene deleted the reusable_workflows branch December 18, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants