Upgraded golangci-lint to 1.52.2 (latest). #1389
Conversation
There was a problem hiding this comment.
This only updates custom tasks "setup" so I don't think it unblocks any pipeline PR tektoncd/pipeline#6518 🤔
|
https://github.com/tektoncd/plumbing/blob/main/tekton/images/test-runner/Dockerfile#L177 is where it should change. |
This enables some new linters and disables some deprecated ones. Context: tektoncd/pipeline#5899 This PR is step one in unblocking tektoncd/pipeline#6518 /kind cleanup
Thank you -- I was modeling on #1308 and somehow missed that file. Fixed! |
Right, this is |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/woof |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign dibyom |
|
/lgtm |
This change will update our plumbing to include #1389 as well as any other changes since the last upgrade. Context: tektoncd/pipeline#6518 Issue: tektoncd/pipeline#5899 /kind cleanup
Changes
This upgrade enables some new linters and disables some deprecated ones.
Context: tektoncd/pipeline#5899
This PR is step one in unblocking tektoncd/pipeline#6518
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: