Document conditional error with permission script ✍️ #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While updating permissions so that @jerop can step in as a governing board member while I am on leave, I ran into an interruption in the script execution b/c there was a conditional IAM policy on tekton-nightly. I traced this back to a conditional policy which gave @priyawadhwa temporary access (via her Google account at the time) but had already expired in 2021. After removing this conditional policy the script ran just fine so I added a brief troubleshooting section to the script's docs to try to explain this if anyone runs into it in the future.
priyawadhwa
approved these changes
Apr 11, 2022
bobcatfish
added a commit
to bobcatfish/community
that referenced
this pull request
Apr 11, 2022
1. Finishing up updates from governing board election (andrew bayer no longer on the board, priya wadhwa joining the board) 2. jerop@ will be taking my place on the governing board while I am on leave (see [leave policy](https://github.com/tektoncd/community/blob/main/governance.md#governing-board-leave-policy)) (thanks jerop@ !!) Went through the list at https://github.com/tektoncd/community/blob/main/governance.md#changes-to-governing-board to make sure jerop and priya have all the governing board permissions and to make the changes required with andrew leaving the board. While running the permissions adding script I ran into a couple of difficulties which I've tried to fix in: * tektoncd/plumbing#1062 * tektoncd/plumbing#1061
bobcatfish
added a commit
to bobcatfish/community
that referenced
this pull request
Apr 11, 2022
1. Finishing up updates from governing board election (andrew bayer no longer on the board, priya wadhwa joining the board) 2. jerop@ will be taking my place on the governing board while I am on leave (see [leave policy](https://github.com/tektoncd/community/blob/main/governance.md#governing-board-leave-policy)) (thanks jerop@ !!) Went through the list at https://github.com/tektoncd/community/blob/main/governance.md#changes-to-governing-board to make sure jerop and priya have all the governing board permissions and to make the changes required with andrew leaving the board. Also added Priti to the governing board + community meeting faciltator rotation because she is listed in the rotation in the doc. While running the permissions adding script I ran into a couple of difficulties which I've tried to fix in: * tektoncd/plumbing#1062 * tektoncd/plumbing#1061
bobcatfish
added a commit
to bobcatfish/community
that referenced
this pull request
Apr 11, 2022
1. Finishing up updates from governing board election (andrew bayer no longer on the board, priya wadhwa joining the board) 2. @jerop will be taking my place on the governing board while I am on leave (see [leave policy](https://github.com/tektoncd/community/blob/main/governance.md#governing-board-leave-policy)) (thanks @jerop !!) Went through the list at https://github.com/tektoncd/community/blob/main/governance.md#changes-to-governing-board to make sure jerop and priya have all the governing board permissions and to make the changes required with andrew leaving the board. Also added Priti to the governing board + community meeting faciltator rotation because she is listed in the rotation in the doc. While running the permissions adding script I ran into a couple of difficulties which I've tried to fix in: * tektoncd/plumbing#1062 * tektoncd/plumbing#1061
bobcatfish
added a commit
to bobcatfish/community
that referenced
this pull request
Apr 11, 2022
1. Finishing up updates from governing board election (andrew bayer no longer on the board, priya wadhwa joining the board) 2. @jerop will be taking my place on the governing board while I am on leave (see [leave policy](https://github.com/tektoncd/community/blob/main/governance.md#governing-board-leave-policy)) (thanks @jerop !!) Went through the list at https://github.com/tektoncd/community/blob/main/governance.md#changes-to-governing-board to make sure jerop and priya have all the governing board permissions and to make the changes required with andrew leaving the board. Also added Priti to the governing board + community meeting faciltator rotation because she is listed in the rotation in the doc. While running the permissions adding script I ran into a couple of difficulties which I've tried to fix in: * tektoncd/plumbing#1062 * tektoncd/plumbing#1061
vdemeester
approved these changes
Apr 12, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
pushed a commit
to tektoncd/community
that referenced
this pull request
Apr 12, 2022
1. Finishing up updates from governing board election (andrew bayer no longer on the board, priya wadhwa joining the board) 2. @jerop will be taking my place on the governing board while I am on leave (see [leave policy](https://github.com/tektoncd/community/blob/main/governance.md#governing-board-leave-policy)) (thanks @jerop !!) Went through the list at https://github.com/tektoncd/community/blob/main/governance.md#changes-to-governing-board to make sure jerop and priya have all the governing board permissions and to make the changes required with andrew leaving the board. Also added Priti to the governing board + community meeting faciltator rotation because she is listed in the rotation in the doc. While running the permissions adding script I ran into a couple of difficulties which I've tried to fix in: * tektoncd/plumbing#1062 * tektoncd/plumbing#1061
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While updating permissions so that @jerop can step in as a governing
board member while I am on leave, I ran into an interruption in the
script execution b/c there was a conditional IAM policy on
tekton-nightly. I traced this back to a conditional policy which gave
@priyawadhwa temporary access (via her Google account at the time) but
had already expired in 2021. After removing this conditional policy the
script ran just fine so I added a brief troubleshooting section to the
script's docs to try to explain this if anyone runs into it in the
future.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.