-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using pipeline resources in create-release-draft #1019
Conversation
Create a pipeline that uses git-clone, gcs-download and create-release-draft instead of the single task with PipelineResources. Update the template slightly to mark optional fields as comments. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Related to #58 |
Docs need to be updated on pipeline side. |
a48dfa6
to
ef3c6a2
Compare
Add the attestation part to the release template. Take Rekor UUID as new input params. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
ef3c6a2
to
106eb9d
Compare
With tektoncd/plumbing#1019 the release draft process is now a pipeline as it does not use pipeline resources anymore. The new template also include support for rekor. Update the cheatsheet accordingly. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With tektoncd/plumbing#1019 the release draft process is now a pipeline as it does not use pipeline resources anymore. The new template also include support for rekor. Update the cheatsheet accordingly. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Changes
Create a pipeline that uses git-clone, gcs-download and
create-release-draft instead of the single task with PipelineResources.
Update the template slightly to mark optional fields as comments.
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
/kind misc