Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using pipeline resources in create-release-draft #1019

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Mar 16, 2022

Changes

Create a pipeline that uses git-clone, gcs-download and
create-release-draft instead of the single task with PipelineResources.

Update the template slightly to mark optional fields as comments.

Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

/kind misc

Create a pipeline that uses git-clone, gcs-download and
create-release-draft instead of the single task with PipelineResources.

Update the template slightly to mark optional fields as comments.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@afrittoli
Copy link
Member Author

Related to #58

@afrittoli
Copy link
Member Author

afrittoli commented Mar 16, 2022

Docs need to be updated on pipeline side.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Mar 16, 2022
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2022
@afrittoli afrittoli force-pushed the release_drafter branch 3 times, most recently from a48dfa6 to ef3c6a2 Compare March 16, 2022 20:27
Add the attestation part to the release template.
Take Rekor UUID as new input params.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
afrittoli added a commit to afrittoli/pipeline that referenced this pull request Mar 16, 2022
With tektoncd/plumbing#1019 the release
draft process is now a pipeline as it does not use pipeline
resources anymore. The new template also include support for
rekor. Update the cheatsheet accordingly.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit f303e66 into tektoncd:main Mar 17, 2022
tekton-robot pushed a commit to tektoncd/pipeline that referenced this pull request Mar 17, 2022
With tektoncd/plumbing#1019 the release
draft process is now a pipeline as it does not use pipeline
resources anymore. The new template also include support for
rekor. Update the cheatsheet accordingly.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants