{taskrun,pipelinerun}metrics: make sure config is up-to-date

[vdemeester]

Changes

This updates some metrics package and struct to be able to keep up-to-date the metrics configuration in the background go routines that are used.

Loosly depends on #8184.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[vdemeester]

/kind misc

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/controller.go	81.5%	82.1%	0.7
pkg/reconciler/taskrun/controller.go	85.2%	85.7%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/controller.go	81.5%	82.1%	0.7
pkg/reconciler/taskrun/controller.go	85.2%	85.7%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/controller.go	81.5%	82.1%	0.7
pkg/reconciler/taskrun/controller.go	85.2%	85.7%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.9%	85.4%	0.5
pkg/reconciler/pipelinerun/controller.go	81.5%	82.1%	0.7
pkg/reconciler/taskrun/controller.go	85.2%	85.7%	0.5
pkg/taskrunmetrics/metrics.go	86.4%	86.6%	0.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.9%	85.4%	0.5
pkg/reconciler/pipelinerun/controller.go	81.5%	82.1%	0.7
pkg/reconciler/taskrun/controller.go	85.2%	85.7%	0.5
pkg/taskrunmetrics/metrics.go	86.4%	86.6%	0.2

[gabemontero]

fwiw I was able to verify this change against main branch, along with some temporary logging to prove non-default config.observability changes are picked up, using ko applly -R -f ./config on a local kind cluster

[piyush-garg]

/lgtm

[chitrangpatel]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chitrangpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gabemontero]

any chance @vdemeester this could be cherrypicked as far back as 0.61.x ?

@khrm @divyansh42 FYI

[vdemeester]

/cherry-pick release-v0.62.x

[vdemeester]

/cherry-pick release-v0.59.x

[vdemeester]

/cherry-pick release-v0.56.x

[vdemeester]

/cherry-pick release-v0.53.x

[tekton-robot]

@vdemeester: new pull request created: #8198

In response to this:

/cherry-pick release-v0.62.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@vdemeester: #8187 failed to apply on top of branch "release-v0.59.x":

Applying: {taskrun,pipelinerun}metrics: make sure config is up-to-date
Using index info to reconstruct a base tree...
M	pkg/pipelinerunmetrics/metrics.go
M	pkg/pipelinerunmetrics/metrics_test.go
M	pkg/reconciler/pipelinerun/controller.go
M	pkg/reconciler/taskrun/controller.go
M	pkg/taskrunmetrics/metrics.go
M	pkg/taskrunmetrics/metrics_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/taskrunmetrics/metrics_test.go
Auto-merging pkg/taskrunmetrics/metrics.go
CONFLICT (content): Merge conflict in pkg/taskrunmetrics/metrics.go
Auto-merging pkg/reconciler/taskrun/controller.go
Auto-merging pkg/reconciler/pipelinerun/controller.go
Auto-merging pkg/pipelinerunmetrics/metrics_test.go
Auto-merging pkg/pipelinerunmetrics/metrics.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 {taskrun,pipelinerun}metrics: make sure config is up-to-date
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.59.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@vdemeester: #8187 failed to apply on top of branch "release-v0.56.x":

Applying: {taskrun,pipelinerun}metrics: make sure config is up-to-date
Using index info to reconstruct a base tree...
M	pkg/pipelinerunmetrics/metrics.go
M	pkg/pipelinerunmetrics/metrics_test.go
M	pkg/reconciler/pipelinerun/controller.go
M	pkg/reconciler/taskrun/controller.go
M	pkg/taskrunmetrics/metrics.go
M	pkg/taskrunmetrics/metrics_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/taskrunmetrics/metrics_test.go
Auto-merging pkg/taskrunmetrics/metrics.go
CONFLICT (content): Merge conflict in pkg/taskrunmetrics/metrics.go
Auto-merging pkg/reconciler/taskrun/controller.go
Auto-merging pkg/reconciler/pipelinerun/controller.go
Auto-merging pkg/pipelinerunmetrics/metrics_test.go
Auto-merging pkg/pipelinerunmetrics/metrics.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 {taskrun,pipelinerun}metrics: make sure config is up-to-date
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@vdemeester: #8187 failed to apply on top of branch "release-v0.53.x":

Applying: {taskrun,pipelinerun}metrics: make sure config is up-to-date
Using index info to reconstruct a base tree...
M	pkg/pipelinerunmetrics/metrics.go
M	pkg/pipelinerunmetrics/metrics_test.go
M	pkg/reconciler/pipelinerun/controller.go
M	pkg/reconciler/taskrun/controller.go
M	pkg/taskrunmetrics/metrics.go
M	pkg/taskrunmetrics/metrics_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/taskrunmetrics/metrics_test.go
Auto-merging pkg/taskrunmetrics/metrics.go
CONFLICT (content): Merge conflict in pkg/taskrunmetrics/metrics.go
Auto-merging pkg/reconciler/taskrun/controller.go
CONFLICT (content): Merge conflict in pkg/reconciler/taskrun/controller.go
Auto-merging pkg/reconciler/pipelinerun/controller.go
CONFLICT (content): Merge conflict in pkg/reconciler/pipelinerun/controller.go
Auto-merging pkg/pipelinerunmetrics/metrics_test.go
Auto-merging pkg/pipelinerunmetrics/metrics.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 {taskrun,pipelinerun}metrics: make sure config is up-to-date
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.