Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use tagged images to take advantage of the least expensive default image pull policy #8133

Merged
merged 1 commit into from
Jul 18, 2024
Merged

use tagged images to take advantage of the least expensive default image pull policy #8133

merged 1 commit into from
Jul 18, 2024

Conversation

pritidesai
Copy link
Member

Changes

Replace the latest tag with the latest version and tag the image to take advantage of the least expensive k8s default image pull policy. The current policy is:

  • if you omit the imagePullPolicy field, and the tag for the container image is :latest, imagePullPolicy is automatically set to Always
  • if you omit the imagePullPolicy field, and you don't specify the tag for the container image, imagePullPolicy is automatically set to Always

With this change, we are relying on the following policy:

  • if you omit the imagePullPolicy field, and you specify the tag for the container image that isn't :latest, the imagePullPolicy is automatically set to IfNotPresent.

Part of #4551

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@pritidesai
use tagged images
440f143 
Replace latest tag with the latest version and tag the image to avoid
k8s default image pull policy. The policy is:

* if you omit the imagePullPolicy field, and the tag for the container image is
  :latest, imagePullPolicy is automatically set to Always
* if you omit the imagePullPolicy field, and you don't specify the tag for the
  container image, imagePullPolicy is automatically set to Always

With this change, we are relying on the following policy:

* if you omit the imagePullPolicy field, and you specify the tag for the container
  image that isn't :latest, the imagePullPolicy is automatically set to IfNotPresent.

Signed-off-by: Priti Desai <pdesai@us.ibm.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jul 18, 2024
@tekton-robot tekton-robot requested review from dibyom and jerop July 18, 2024 00:27
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 18, 2024
chitrangpatel
chitrangpatel approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@chitrangpatel chitrangpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@chitrangpatel
Copy link
Contributor

/test pull-tekton-pipeline-integration-tests

chitrangpatel
chitrangpatel reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@chitrangpatel chitrangpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now but my only fear with this is maintaining the version tags every once in a while. I think thats an ok compromise.

@chitrangpatel
Copy link
Contributor

/retest

@chitrangpatel
Copy link
Contributor

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit 38f2cb5 into tektoncd:main Jul 18, 2024
14 checks passed
@pritidesai
Copy link
Member Author

Approving for now but my only fear with this is maintaining the version tags every once in a while. I think thats an ok compromise.

Yes, this is an additional maintenance until we find a permanent solution. However, it only requires infrequent updates.

@pritidesai pritidesai deleted the fix-image-rate-limit branch July 18, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@jerop jerop Awaiting requested review from jerop

Assignees

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pritidesai @tekton-robot @chitrangpatel