Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bobcatfish and lbernick from OWNERS 😿 #8047

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Remove bobcatfish and lbernick from OWNERS 😿 #8047

merged 1 commit into from
Jun 18, 2024

Conversation

vdemeester
Copy link
Member

Changes

@bobcatfish and @lbernick are not working on tektoncd anymore, thus it
doesn't make sense to keep them as OWNERS in the project.

Thank you both for everything you did on the project 🤗.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc
/meow sad

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@vdemeester
Remove bobcatfish and lbernick from OWNERS 😿
15b4602 
@bobcatfish and @lbernick are not working on tektoncd anymore, thus it
doesn't make sense to keep them as OWNERS in the project.

Thank you both for everything you did on the project 🤗.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 12, 2024
@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

Changes

@bobcatfish and @lbernick are not working on tektoncd anymore, thus it
doesn't make sense to keep them as OWNERS in the project.

Thank you both for everything you did on the project 🤗.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc
/meow sad

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2024
@vdemeester
Copy link
Member Author

/assign @afrittoli @chitrangpatel @JeromeJu @dibyom @jerop

vdemeester added a commit to vdemeester/tektoncd-community that referenced this pull request Jun 12, 2024
@vdemeester
org: update some team members
7b9acb2 
Related to tektoncd/pipeline#8047 but not
only. I think this file needs a bit more cleaning still.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester vdemeester mentioned this pull request Jun 12, 2024
Merged
@chitrangpatel
Copy link
Contributor

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor

/retest

@vdemeester
Copy link
Member Author

@chitrangpatel I think pull-tekton-pipeline-go-coverage-df is not required (look at the tide check) so I think we are fine with it being 🔴

@chitrangpatel
Copy link
Contributor

Thank you @bobcatfish, @lbernick !!!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@lbernick
Copy link
Member

❤️

khrm
khrm reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@khrm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

Sad PR :(
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-go-coverage-df
/test pull-tekton-pipeline-go-coverage

@vdemeester
Copy link
Member Author

/override pull-tekton-pipeline-go-coverage-df

@vdemeester
Copy link
Member Author 

repository 'https://github.com/$(tasks.split-full-repo-name.results.repoOwner)/$(tasks.split-full-repo-name.results.repoName).git/' not found

🤔

vdemeester added a commit to vdemeester/tektoncd-community that referenced this pull request Jun 18, 2024
@vdemeester
org: update some team members
996cd72 
Related to tektoncd/pipeline#8047 but not
only. I think this file needs a bit more cleaning still.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member Author

@tektoncd/plumbing-maintainers there is an issue with the reports of the tekton-powered jobs. pull-tekton-pipeline-go-coverage-df is still running but the check is marked as successful already.

This was referenced Jun 18, 2024
Open
Open
@vdemeester
Copy link
Member Author

(It did succeed this time though)

@tekton-robot tekton-robot merged commit a739152 into tektoncd:main Jun 18, 2024
14 checks passed
@vdemeester vdemeester deleted the update-owners branch June 18, 2024 08:03
vdemeester added a commit to vdemeester/tektoncd-community that referenced this pull request Jun 18, 2024
@vdemeester
org: update some team members
0b7dc67 
Related to tektoncd/pipeline#8047 but not
only. I think this file needs a bit more cleaning still.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot pushed a commit to tektoncd/community that referenced this pull request Jun 19, 2024
@vdemeester @tekton-robot
org: update some team members
ae752eb 
Related to tektoncd/pipeline#8047 but not
only. I think this file needs a bit more cleaning still.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@afrittoli afrittoli

@dibyom dibyom

@chitrangpatel chitrangpatel

@jerop jerop

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vdemeester @tekton-robot @chitrangpatel @lbernick @afrittoli @khrm @dibyom @jerop @JeromeJu