Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Example Test point to Catalog StepAction #8044

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix: Example Test point to Catalog StepAction #8044

merged 1 commit into from
Jun 11, 2024

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Jun 10, 2024 •
edited
Loading

Prior to this, the e2e test was pointing to chitrangpatel's private repository. This unintentionally broke our CI since the example test started to fail.
Now that we have a catalog of StepActions, point there instead.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind bug

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesnt merit a release note. labels Jun 10, 2024
@tekton-robot tekton-robot requested review from jerop and vdemeester June 10, 2024 19:30
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2024
@QuanZhang-William
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@chitrangpatel chitrangpatel force-pushed the fix-remote-step-action branch from 5784e65 to 8800a87 Compare June 10, 2024 19:50
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
vdemeester
vdemeester approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@chitrangpatel
Copy link
Contributor Author

/reteat

@JeromeJu
Copy link
Member

/lgtm
/retest

@JeromeJu
Copy link
Member

/retest

@chitrangpatel
Fix: Example Test point to Catalog StepAction
72dc021 
Prior to this, the e2e test was pointing to chitrangpatel's private
repository. This unintentionally broke our CI since the example test
started to fail.
Now that we have a catalog of StepActions, point there instead.
@chitrangpatel chitrangpatel force-pushed the fix-remote-step-action branch from 8800a87 to 72dc021 Compare June 10, 2024 22:18
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2024
@JeromeJu
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@tekton-robot tekton-robot merged commit b0f294e into tektoncd:main Jun 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop Awaiting requested review from jerop

Assignees

@vdemeester vdemeester

@QuanZhang-William QuanZhang-William

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chitrangpatel @QuanZhang-William @tekton-robot @JeromeJu @vdemeester @Yongxuanzhang