Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.56.x] fix: when using remote resources, the related metrics tag name is wrong #7956

Merged
merged 1 commit into from
May 17, 2024
Merged

[release-v0.56.x] fix: when using remote resources, the related metrics tag name is wrong #7956

merged 1 commit into from
May 17, 2024

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #7731

/assign afrittoli

NONE

@cugykw
Prior to this PR, when pipeline refers to a remote pipeline, in the p…
b9e8592 
…ipeline-related metrics, the pipeline name tag will be set to 'anonymous'. Taskrun has the same situation.

This commit added some scenarios for obtaining pipeline or task names.
When the pipeline or task name cannot be determined accurately,
the value is obtained through the corresponding label.
@tekton-robot tekton-robot mentioned this pull request May 17, 2024
Merged
8 tasks
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2024
@tekton-robot tekton-robot requested review from dibyom and vdemeester May 17, 2024 09:27
@afrittoli
Copy link
Member

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 17, 2024
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/metrics.go 84.9% 83.8% -1.2
pkg/taskrunmetrics/metrics.go 86.4% 84.4% -2.1

@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/metrics.go 84.9% 83.8% -1.2
pkg/taskrunmetrics/metrics.go 86.4% 84.4% -2.1

@vdemeester
Copy link
Member

/retest
/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@tekton-robot tekton-robot merged commit 6cbfbcd into tektoncd:release-v0.56.x May 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom Awaiting requested review from dibyom

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tekton-robot @afrittoli @vdemeester @cugykw