-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image replacement for amd64 specific image for entrypoint-resolution test and update docker-in-docker test image for Power. #7937
Conversation
Hi @Sachin-Itagi. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/kind misc |
1f21b29
to
ddee75c
Compare
/retest |
ddee75c
to
3b1ca7d
Compare
/test pull-tekton-pipeline-go-coverage |
/approve |
3b1ca7d
to
9fd52d5
Compare
@chitrangpatel Can we proceed with the merge if everything looks good to you. All the checks were successful. |
Signed-off-by: Sachin Itagi <sachin.itagi@ibm.com>
9fd52d5
to
766cb3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This includes replacing the amd64/ubuntu image for entrypoint-resolution test and update the docker:dind image in the test examples. this is not multi arch image, so use different image for ppc64le platform.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes