Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image replacement for amd64 specific image for entrypoint-resolution test and update docker-in-docker test image for Power. #7937

Merged
merged 1 commit into from
May 16, 2024

Conversation

Sachin-Itagi
Copy link
Contributor

This includes replacing the amd64/ubuntu image for entrypoint-resolution test and update the docker:dind image in the test examples. this is not multi arch image, so use different image for ppc64le platform.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2024
@tekton-robot
Copy link
Collaborator

Hi @Sachin-Itagi. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot requested review from abayer and afrittoli May 9, 2024 10:33
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2024
@khrm
Copy link
Contributor

khrm commented May 9, 2024

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label May 9, 2024
@Sachin-Itagi Sachin-Itagi force-pushed the fixPipelineTestPower branch from 1f21b29 to ddee75c Compare May 10, 2024 03:42
@Sachin-Itagi
Copy link
Contributor Author

/retest

@Sachin-Itagi Sachin-Itagi force-pushed the fixPipelineTestPower branch from ddee75c to 3b1ca7d Compare May 10, 2024 04:21
@Sachin-Itagi
Copy link
Contributor Author

/test pull-tekton-pipeline-go-coverage

@chitrangpatel
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@Sachin-Itagi Sachin-Itagi force-pushed the fixPipelineTestPower branch from 3b1ca7d to 9fd52d5 Compare May 14, 2024 03:54
@Sachin-Itagi
Copy link
Contributor Author

@chitrangpatel Can we proceed with the merge if everything looks good to you. All the checks were successful.

Signed-off-by: Sachin Itagi <sachin.itagi@ibm.com>
@Sachin-Itagi Sachin-Itagi force-pushed the fixPipelineTestPower branch from 9fd52d5 to 766cb3a Compare May 16, 2024 03:46
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chitrangpatel,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit ee68bcc into tektoncd:main May 16, 2024
13 checks passed
@Sachin-Itagi Sachin-Itagi deleted the fixPipelineTestPower branch May 16, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants