-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deadline Exceeded to transient error in resolver #7893
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind bug
The following is the coverage report on the affected files.
|
Sometime webhook or git server might take time, so we need to add deadline exceeded to transient error.
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/hold |
We probably need this only for specific error like pipelines-webhook issue. |
fyi @khrm I've opened #7909 and at the moment have updated my PR #7894 to say it fixes the new issue, where my PR checks for these transient errors on both the core controller and remote resolver side. I know we only touched on this just briefly in one of our team meetings today. But either here or in slack let me know which PR you want to focus our efforts on. And of course, if you disagree with my checks in both controllers, let's discuss. Thanks. |
Merged. We can close this. |
@khrm: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sometime webhook or git server might take time, so we need to add deadline exceeded to transient error.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes