Fix showing error message when validation fail #7509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When step action is used in step, and feature flag is not enabled, the error message is not shown correctly and would show a %s. We are now using fmt.Sprintf to format the error message and show the feature flag that need to be enabled properly. apis.ErrGeneric need a empty string as second argument to be able to show the path steps so adding this. Fixes bug tektoncd#7493 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
vdemeester
approved these changes
Dec 20, 2023
JeromeJu
approved these changes
Dec 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When step action is used in step, and feature flag is not enabled, the
error message is not shown correctly and would show a %s.
We are now using fmt.Sprintf to format the error message and show the
feature flag that need to be enabled properly. apis.ErrGeneric need a
empty string as second argument to be able to show the path steps so
adding this.
errror message should now show:
instead of:
Fixes bug #7493
Signed-off-by: Chmouel Boudjnah chmouel@redhat.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind misc