git-init: trim spaces from url (and remove dead code) #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
|
/test pull-tekton-pipeline-integration-tests |
if the given url contains some spaces (like non-breaking spaces), `git-init` may fail with `protocol ' https' is not supported`. This fixes that. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
c4166c8 to
c003564
Compare
abayer
reviewed
Apr 11, 2019
cmd/git-init/main.go
Outdated
| if err := os.Chdir(*path); err != nil { | ||
| logger.Fatalf("Failed to change directory with path %s; err %v", path, err) | ||
| } | ||
| } else { | ||
| runOrFail(logger, "git", "init") | ||
| } | ||
|
|
||
| runOrFail(logger, "git", "remote", "add", "origin", *url) | ||
| trimedURL := strings.TrimSpace(*url) |
this statement won't ever be true : either `git init` failed and we left, *or* `git init` succeeded and the path exists. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
c003564 to
ddb526c
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
git-initmay fail withprotocol ' https' is not supported. Thisfixes that.
git initfailed and weleft already, or
git initsucceeded and the path exists.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.