Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.53.x] Fix: do not fail TaskRun for concurrent modification errors #7479

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[release-v0.53.x] Fix: do not fail TaskRun for concurrent modification errors #7479

merged 1 commit into from
Dec 13, 2023

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #7467

/assign JeromeJu

fix: taskRuns will not fail for concurrent modification errors when stopping sideCars

@tekton-robot tekton-robot mentioned this pull request Dec 11, 2023
Merged
7 tasks
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2023
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 11, 2023
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 85.2% 84.7% -0.5

@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 85.2% 84.7% -0.5

@JeromeJu
Copy link
Member

JeromeJu commented Dec 12, 2023 •
edited
Loading

We would need a manual cherry pick at #7364 (comment) for this PR.

@JeromeJu
Copy link
Member

JeromeJu commented Dec 13, 2023 •
edited
Loading

#7490 is raised as the prerequisite

@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@JeromeJu
Copy link
Member

JeromeJu commented Dec 13, 2023 •
edited
Loading

@tekton-robot rebase
Ah alright, this needs manual cherry-pick; tekton-bot doesn't seem to work this way 😅

@JeromeJu
Fix: do not fail TaskRun for concurrent modification errors
f22f6fe 
This commit fixes the behaviour that a concurrent modification error
when stopping sidecar will fail the TaskRun, which could cause
successful Tasks to fail even though it could succeed after retrying.

/kind bug
@JeromeJu JeromeJu force-pushed the cherry-pick-7467-to-release-v0.53.x branch from 1c3c7fd to f22f6fe Compare December 13, 2023 21:10
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 85.2% 84.7% -0.5

@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 85.2% 84.7% -0.5

@JeromeJu
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023
@tekton-robot tekton-robot merged commit 597f386 into tektoncd:release-v0.53.x Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeJu JeromeJu JeromeJu approved these changes

@dibyom dibyom dibyom approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tekton-robot @JeromeJu @dibyom