Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue where resolutionrequest defaulted to v1alpha1 vs v1beta1 #7438

Merged

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Nov 29, 2023

/kind cleanup

Changes

It was identified that the default APIVersion was v1alpha1 in pkg/apis/resolution/v1beta1/resolution_request_defaults.go when it should be v1beta1. This PR fixes this incorrect default API version

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Resolved issue where resolutionrequest defaulted to v1alpha1 when it should be v1beta1

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Nov 29, 2023
@aaron-prindle aaron-prindle reopened this Nov 30, 2023
@aaron-prindle aaron-prindle force-pushed the fix-resolutionrequest-default-api branch from 3c716a0 to 43540b5 Compare November 30, 2023 00:25
@jerop
Copy link
Member

jerop commented Nov 30, 2023

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2023
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @aaron-prindle!

I was wondering if we even need this defaulting, because how is the object a ResolutionRequest if the APIVersion and Kind is not set? The defaulting we have on the other CRDs is on the Spec and Status, not on the APIVersion and Kind of the object itself. Maybe this is why this issue has not been caught in the 1yr+ since v1betat1.ResolutionRequest was released. I wonder if it'd better to remove this defaulting, or whether I'm missing something obvious.

cc @tektoncd/core-maintainers

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@jerop
Copy link
Member

jerop commented Nov 30, 2023

recorded my questions in #7447 to unblock this fix

thanks @aaron-prindle

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@tekton-robot tekton-robot merged commit d7f8c99 into tektoncd:main Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants