-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve issue where resolutionrequest defaulted to v1alpha1 vs v1beta1 #7438
fix: resolve issue where resolutionrequest defaulted to v1alpha1 vs v1beta1 #7438
Conversation
3c716a0
to
43540b5
Compare
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix @aaron-prindle!
I was wondering if we even need this defaulting, because how is the object a ResolutionRequest if the APIVersion and Kind is not set? The defaulting we have on the other CRDs is on the Spec and Status, not on the APIVersion and Kind of the object itself. Maybe this is why this issue has not been caught in the 1yr+ since v1betat1.ResolutionRequest was released. I wonder if it'd better to remove this defaulting, or whether I'm missing something obvious.
cc @tektoncd/core-maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
recorded my questions in #7447 to unblock this fix thanks @aaron-prindle /lgtm |
/kind cleanup
Changes
It was identified that the default APIVersion was
v1alpha1
in pkg/apis/resolution/v1beta1/resolution_request_defaults.go when it should bev1beta1
. This PR fixes this incorrect default API versionSubmitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes