Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0142: Add syntax for providing params to StepActions #7334

Merged
merged 1 commit into from
Nov 7, 2023
Merged

TEP-0142: Add syntax for providing params to StepActions #7334

merged 1 commit into from
Nov 7, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Nov 6, 2023 •
edited
Loading

Following the previous PR, which introduced Params to the StepAction CRD, this PR integrates param usage between Steps and StepActions. This PR adds the necessary syntax to Steps to pass params to StepActions. This work is part of issue #7259. The actual resolution of the params and passing them to StepActions will be completed in PR #7332.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@chitrangpatel chitrangpatel mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chitrangpatel
Copy link
Contributor Author

/hold wait for #7332

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023
@chitrangpatel
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023
@chitrangpatel
Copy link
Contributor Author

/retest

@QuanZhang-William
Copy link
Member

/assign

@chitrangpatel chitrangpatel mentioned this pull request Nov 6, 2023
Closed
20 tasks
@chitrangpatel
TEP-0142: Add syntax for providing params to StepActions
a8e1e14 
Following the previous [PR](tektoncd#7317), which introduced Params to the `StepAction` CRD,
this PR integrates `param` usage between `Steps` and `StepActions`. This PR adds the necessary syntax to `Steps` to pass `params` to `StepActions`. This work is part of
issue tektoncd#7259.
@chitrangpatel chitrangpatel force-pushed the step-action-params-syntax branch from f99b39d to a8e1e14 Compare November 6, 2023 19:25
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@chitrangpatel chitrangpatel requested a review from jerop November 6, 2023 20:17
jerop
jerop approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@jerop
Copy link
Member

jerop commented Nov 7, 2023

@tektoncd/core-maintainers @tektoncd/core-collaborators please take a look

Yongxuanzhang
Yongxuanzhang approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, QuanZhang-William, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop
Copy link
Member

jerop commented Nov 7, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@tekton-robot tekton-robot merged commit 7e3897a into tektoncd:main Nov 7, 2023
2 checks passed
@jerop jerop added this to the Pipelines v0.54 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@QuanZhang-William QuanZhang-William QuanZhang-William approved these changes

@jerop jerop jerop approved these changes

@abayer abayer Awaiting requested review from abayer

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@jerop jerop

@QuanZhang-William QuanZhang-William

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.54
Development

Successfully merging this pull request may close these issues.
5 participants
@chitrangpatel @tekton-robot @QuanZhang-William @jerop @Yongxuanzhang