Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hub resolver: add version constraints #7257

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Hub resolver: add version constraints #7257

merged 1 commit into from
Oct 24, 2023

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Oct 23, 2023 •
edited
Loading

This let the user specify a version constraint to choose from.

Version constraint looks like this:

version: ">= 0.5.0"

This will only choose the tasks that are greater than 0.5.0

Additional constraint operators are available, for example:

version: ">= 0.5.0, < 2.0.0"

/kind feature

This will only choose the tasks that are greater than 0.5.0 and less than 2.0.0

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

hub resolver can now specify a version constraint to choose a version (example: version: ">=0.2.0,< 1.0.0")

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 23, 2023
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/resolvers/main.go Do not exist 55.6%
pkg/resolution/resolver/hub/resolver.go 76.9% 77.9% 1.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/resolvers/main.go Do not exist 55.6%
pkg/resolution/resolver/hub/resolver.go 76.9% 77.9% 1.0

@chmouel chmouel force-pushed the hub-version-comparaisons branch from 7d1a1aa to 1a2e3d6 Compare October 23, 2023 14:41
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/resolvers/main.go Do not exist 55.6%
pkg/resolution/resolver/hub/resolver.go 76.9% 77.9% 1.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/resolvers/main.go Do not exist 55.6%
pkg/resolution/resolver/hub/resolver.go 76.9% 77.9% 1.0

@chmouel chmouel force-pushed the hub-version-comparaisons branch from 1a2e3d6 to 9b65e39 Compare October 23, 2023 15:01
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/resolvers/main.go Do not exist 55.6%
pkg/resolution/resolver/hub/resolver.go 76.9% 77.2% 0.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/resolvers/main.go Do not exist 55.6%
pkg/resolution/resolver/hub/resolver.go 76.9% 77.2% 0.3

jerop
jerop reviewed Oct 23, 2023
View reviewed changes
docs/hub-resolver.md Outdated Show resolved Hide resolved
@chmouel
Hub resolver: add version constraints
62edf69 
This let the user specify a version constraint to choose from.

Version constraint looks like this:

```yaml
version: ">= 0.5.0"
```

This will only choose the tasks that are greater than 0.5.0

Additional constraint operators are available, for example:

```yaml
version: ">= 0.5.0, < 2.0.0"
```

This will only choose the tasks that are greater than 0.5.0 and less
than 2.0.0

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel force-pushed the hub-version-comparaisons branch from 9b65e39 to 62edf69 Compare October 23, 2023 15:27
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/resolvers/main.go Do not exist 55.6%
pkg/resolution/resolver/hub/resolver.go 76.9% 77.2% 0.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/resolvers/main.go Do not exist 55.6%
pkg/resolution/resolver/hub/resolver.go 76.9% 77.2% 0.3

@chmouel
Copy link
Member Author

chmouel commented Oct 23, 2023

I used go-version since the dependency was already there (as indirect dep) there is as well semver which seems as good (but better documented) but not having to add a new deps to maintain/tracks wins everything imho :)

jerop
jerop approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🎉

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop jerop added this to the Pipelines v0.53 LTS milestone Oct 24, 2023
@tekton-robot tekton-robot merged commit f0c7ed5 into tektoncd:main Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.53 LTS
Development

Successfully merging this pull request may close these issues.
4 participants
@chmouel @tekton-robot @vdemeester @jerop