[TEP-0145] Add sanity check for CEL expression #7251
Conversation
|
Skipping CI for Draft Pull Request. |
|
The following is the coverage report on the affected files.
|
| env, err := cel.NewEnv() | ||
| if err != nil { | ||
| return apis.ErrGeneric("err: %s", err.Error()) | ||
| } |
There was a problem hiding this comment.
Since we don't add env declarations here, we won't get errs. So we cannot test the error. Or can we omit this err? 🤔
a9e2e3a to
4c2becd
Compare
|
The following is the coverage report on the affected files.
|
4c2becd to
e144176
Compare
8b81d38 to
19de419
Compare
This commit adds sanity check for CEL expression by pre-compiling the CEL expression at admission webhook without evluation. This can help fail fast if the CEL expression is invalid. And also disallow the usage of variable references without wrapper with single quotes and prevent CEL injection from variables. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
19de419 to
261a7db
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-go-coverage |
|
/lgtm |
|
@chmouel: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
3rd PR of TEP-0145 tracked by #7244.
This commit adds sanity check for CEL expression by pre-compiling the
CEL expression at admission webhook without evluation. This can help
fail fast if the CEL expression is invalid. And also disallow the usage
of variable references without wrapper with single quotes and prevent
CEL injection from variables.
/kind feature
Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes