Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0131] Update Conformance Spec for v1 api types #7224

Merged
merged 1 commit into from
Dec 15, 2023
Merged

[TEP-0131] Update Conformance Spec for v1 api types #7224

merged 1 commit into from
Dec 15, 2023

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Oct 17, 2023 •
edited
Loading

Changes

This commit updates the initial api spec from TEP-012 with changes from the conformance policy defined in TEP-131 including:

  • Using v1 resources instead of v1beta1 types
  • Conformance specs for Tasks, Pipelines and PipelineRuns in addition to TaskRun
  • Removes HTTP API requirement from conformance spec, instead the spec is defined in terms of JSON/YAML resources that can be consumed via an API
  • The RECOMMENDED profile now includes support for taskRefs and pipelineRefs

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Updates the conformance api spec with v1 api types in line with TEP-131

@dibyom dibyom added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 17, 2023
@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 17, 2023
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 17, 2023
@dibyom dibyom marked this pull request as ready for review October 17, 2023 20:25
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2023
@dibyom
Copy link
Member Author

dibyom commented Oct 18, 2023

/cc @afrittoli @vdemeester

afrittoli
afrittoli reviewed Oct 18, 2023
View reviewed changes
docs/api-spec.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
JeromeJu
JeromeJu approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dibyo 🎉

docs/api-spec.md Outdated Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
afrittoli
afrittoli reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dibyom - partial review

docs/api-spec.md Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
docs/api-spec.md Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
docs/api-spec.md Outdated Show resolved Hide resolved
@jerop jerop added this to the Pipelines v0.54 milestone Nov 9, 2023
@dibyom dibyom force-pushed the conformance-spec branch 2 times, most recently from afefb3f to a9baae0 Compare December 5, 2023 17:01
afrittoli
afrittoli reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dibyom - this looks good to me.
The only thing that I was wondering is about the security context in steps, but we don't have to block this PR on that, I'd be happy to go ahead and add the security context in a separate PR is needed.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, JeromeJu, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JeromeJu,afrittoli,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dibyom
[TEP-0131] Update Conformance Spec for v1 api types
4e40916 
This commit updates the initial api spec from TEP-012 with changes from the
conformance policy defined in TEP-131 including:

- Using v1 resources instead of v1beta1 types
- Conformance specs for Tasks, Pipelines and PipelineRuns in addition to TaskRun
- Removes HTTP API requirement from conformance spec, instead the spec is defined in terms of JSON/YAML resources that can be consumed via an API
- The RECOMMENDED profile now includes support for taskRefs and pipelineRefs

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom
Copy link
Member Author

dibyom commented Dec 14, 2023

/test pull-tekton-pipeline-alpha-integration-tests

@afrittoli
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@tekton-robot tekton-robot merged commit e8d3bfd into tektoncd:main Dec 15, 2023
11 checks passed
@dibyom dibyom deleted the conformance-spec branch December 15, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@JeromeJu JeromeJu JeromeJu approved these changes

@vdemeester vdemeester vdemeester approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

@abayer abayer Awaiting requested review from abayer

Assignees

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.55
Development

Successfully merging this pull request may close these issues.
6 participants
@dibyom @tekton-robot @afrittoli @vdemeester @JeromeJu @jerop