Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump versions #6824

Closed
wants to merge 1 commit into from
Closed

Conversation

howardjohn
Copy link
Contributor

Changes

This PR bumps various go.mod dependencies. The intent here is I indirectly import this repo and the mix of dependency versions is causing (minor) problems.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • NA: Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps

  • NA: Has Tests included if any functionality added or changed

  • Follows the commit message standard

  • Meets the Tekton contributor standards (including functionality, content, code)

  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep

  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.

  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind cleanup

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 13, 2023
@tekton-robot tekton-robot requested review from afrittoli and wlynch June 13, 2023 14:34
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 13, 2023
@tekton-robot
Copy link
Collaborator

Hi @howardjohn. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign lbernick after the PR has been reviewed.
You can assign the PR to them by writing /assign @lbernick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2023
@howardjohn
Copy link
Contributor Author

Note the test changes are due to google/go-containerregistry@a0cca8a

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/injection.go 18.2% 11.1% -7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go 31.8% 28.6% -3.2
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.8% 91.7% -2.1
pkg/reconciler/taskrun/resources/taskref.go 90.0% 88.6% -1.4
pkg/taskrunmetrics/injection.go 18.2% 11.1% -7.1

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@howardjohn thanks for the PR, one comment 👼🏼

go.mod Outdated
k8s.io/kube-openapi v0.0.0-20230308215209-15aac26d736a
knative.dev/pkg v0.0.0-20230221145627-8efb3485adcf
k8s.io/kube-openapi v0.0.0-20230515203736-54b630e78af5
knative.dev/pkg v0.0.0-20230612155445-74c4be5e935e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should track a release branch of knative/pkg and ./hack/update-depedencîes.sh should be updated to reflect that.
In addition, we should check if that knative/pkg bump changes the min kubernetes version (if we need to update some of our docs and ci related to that)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a source you use for min k8s version? https://github.com/kubernetes/client-go#compatibility-client-go---kubernetes-clusters seems not updated. Looks like the current min k8s version is 1.24 (https://tekton.dev/docs/pipelines/resolution-getting-started/#prerequisites), IME client-go 1.27 works perfectly fine with k8s 1.24 but not sure the process typically used here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re knative.dev/pkg - I missed the --upgrade part on the update-deps.sh, thanks!

I think this may actually end up breaking things since the latest release of knative/pkg has to old k8s deps. So may need to wait for release-1.11

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@howardjohn we mainly look at this https://github.com/knative/pkg/blob/main/version/version.go#L36 for setting our own kubernetes min version.

(Looks like main pulls 0.26.x https://github.com/knative/pkg/blob/main/go.mod#L46)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok coming back (months later). Knative released 1.11, so this updates to that version. Knative 1.11 has minimum version 1.25: https://github.com/knative/pkg/blob/release-1.11/version/version.go#L36.

1.10 had 1.24, so I think this bumps tekton minimum to 1.25 as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dibyom
Copy link
Member

dibyom commented Jun 13, 2023

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/injection.go 18.2% 11.1% -7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go 31.8% 28.6% -3.2
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.8% 91.7% -2.1
pkg/reconciler/taskrun/resources/taskref.go 90.0% 88.6% -1.4
pkg/taskrunmetrics/injection.go 18.2% 11.1% -7.1

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2023
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/injection.go 18.2% 11.1% -7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go 31.8% 28.6% -3.2
pkg/taskrunmetrics/injection.go 18.2% 11.1% -7.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/injection.go 18.2% 11.1% -7.1
pkg/reconciler/events/cloudevent/cloudeventclient.go 31.8% 28.6% -3.2
pkg/taskrunmetrics/injection.go 18.2% 11.1% -7.1

@tekton-robot
Copy link
Collaborator

tekton-robot commented Jul 21, 2023

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-alpha-integration-tests 2b8b1ea link true /test pull-tekton-pipeline-alpha-integration-tests
pull-tekton-pipeline-beta-integration-tests 2b8b1ea link true /test pull-tekton-pipeline-beta-integration-tests
pull-tekton-pipeline-integration-tests 2b8b1ea link true /test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2023
@tekton-robot
Copy link
Collaborator

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Contributor Author

#6975 handles this

@howardjohn howardjohn closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants