-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: bump versions #6824
go.mod: bump versions #6824
Conversation
Hi @howardjohn. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Note the test changes are due to google/go-containerregistry@a0cca8a |
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howardjohn thanks for the PR, one comment 👼🏼
go.mod
Outdated
k8s.io/kube-openapi v0.0.0-20230308215209-15aac26d736a | ||
knative.dev/pkg v0.0.0-20230221145627-8efb3485adcf | ||
k8s.io/kube-openapi v0.0.0-20230515203736-54b630e78af5 | ||
knative.dev/pkg v0.0.0-20230612155445-74c4be5e935e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should track a release branch of knative/pkg and ./hack/update-depedencîes.sh
should be updated to reflect that.
In addition, we should check if that knative/pkg bump changes the min kubernetes version (if we need to update some of our docs and ci related to that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a source you use for min k8s version? https://github.com/kubernetes/client-go#compatibility-client-go---kubernetes-clusters seems not updated. Looks like the current min k8s version is 1.24 (https://tekton.dev/docs/pipelines/resolution-getting-started/#prerequisites), IME client-go 1.27 works perfectly fine with k8s 1.24 but not sure the process typically used here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re knative.dev/pkg - I missed the --upgrade
part on the update-deps.sh, thanks!
I think this may actually end up breaking things since the latest release of knative/pkg has to old k8s deps. So may need to wait for release-1.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howardjohn we mainly look at this https://github.com/knative/pkg/blob/main/version/version.go#L36 for setting our own kubernetes min version.
(Looks like main pulls 0.26.x https://github.com/knative/pkg/blob/main/go.mod#L46)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok coming back (months later). Knative released 1.11, so this updates to that version. Knative 1.11 has minimum version 1.25: https://github.com/knative/pkg/blob/release-1.11/version/version.go#L36.
1.10 had 1.24, so I think this bumps tekton minimum to 1.25 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howardjohn See #6975 (and tektoncd/plumbing#1520) 😅
/ok-to-test |
The following is the coverage report on the affected files.
|
9854e49
to
777aee4
Compare
777aee4
to
2b8b1ea
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
@howardjohn: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@howardjohn: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#6975 handles this |
Changes
This PR bumps various go.mod dependencies. The intent here is I indirectly import this repo and the mix of dependency versions is causing (minor) problems.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
NA: Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
NA: Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
/kind cleanup