Refactor test cases for remote PipelineRef #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @lbernick |
49bb94e to
34999b8
Compare
lbernick
reviewed
Jun 9, 2023
34999b8 to
1bc5973
Compare
This commit refactors the test cases related with remote pipelineRef, which separates the original TestGetTaskFunc to local, bundle and remote due to the syntax of v1beta1 bundle has been deprecated in v1 and replaced with the bundle resolver. This is similar to the cleanup for TaskRef in tektoncd#6778
1bc5973 to
f870ddf
Compare
lbernick
approved these changes
Jun 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit refactors the test cases related with remote pipelineRef, which separates the original TestGetTaskFunc to local, bundle and remote due to the syntax of v1beta1 bundle has been deprecated in v1 and replaced with the bundle resolver.
This is similar to the cleanup for TaskRef in #6778
NO coverage drop is expected.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes