cmd/git-init: check for errors or at least log them #677
Conversation
- if something fail (even if not fatal), we can at least see it happened - it makes my linter happier 😅 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
| run(logger, "git", "remote", "add", "origin", *url) | ||
| err = run(logger, "git", "fetch", "--depth=1", "--recurse-submodules=yes", "origin", *revision) | ||
| if err != nil { | ||
| runOrFail(logger, "git", "remote", "add", "origin", *url) |
There was a problem hiding this comment.
The reason we don't use runOrFail here is that it uses logger.Fatalf which will log and call Exit(1)
We needed to try the git pull case when this fails
There was a problem hiding this comment.
@pivotal-nader-ziada not sure to follow, the rest of the git commands are all referencing the origin remote. If we failed to add it, nothing else will work.
There was a problem hiding this comment.
Yes, you are right, my bad! I thought it was the fetch
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pivotal-nader-ziada, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…head.sh Modify update-to-head.sh
Changes
happened
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
[ ] Includes tests (if functionality changed/added)[ ] Includes docs (if user facing)See the contribution guide
for more details.