-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate validation for Task/Pipeline beta features #6719
Conversation
Currently, the validation webhook includes code for validating that "enable-api-fields" is set to "beta" when a v1 object is created using beta features. Validation of Task and Pipeline specs is currently applied in the reconciler as well, to referenced Tasks and Pipelines that are fetched remotely or from the cluster. This commit refactors validation of beta features in Tasks and Pipelines, so that it is all done in one place. There are no functional changes in this commit, but it will make it easier to fix issues related to versioned validation of referenced Tasks and Pipelines.
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, JeromeJu, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Currently, the validation webhook includes code for validating that "enable-api-fields" is set to "beta" when a v1 object is created using beta features.
Validation of Task and Pipeline specs is currently applied in the reconciler as well, to referenced Tasks and Pipelines that are fetched remotely or from the cluster. This commit refactors validation of beta features in Tasks and Pipelines, so that it is all done in one place. There are no functional changes in this commit, but it will make it easier to fix issues related to versioned validation of referenced Tasks and Pipelines.
/kind cleanup
Part 1 of #6616
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes