Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Switch storage version to v1 and use v1 in the reconciler #6608

Closed
wants to merge 13 commits into from
Closed

WIP: Switch storage version to v1 and use v1 in the reconciler #6608

wants to merge 13 commits into from

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented May 2, 2023 •
edited
Loading

Changes

[DNM: opening just to see what tests fail]

Unit Tests

  • Cluster Resolver tests failing due to usage of v1beta1 client - fixed in 027f273

Integration test failures

  • Lots of failures in the stable suite, fewer in alpha/beta (details )

  • Most failures due to beta features not being enabled by default with the switch to v1

    • Confirmed by fewer test failures when running the "stable" suite with beta enabled in 54e3fc9

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels May 2, 2023
@tekton-robot tekton-robot requested review from afrittoli and jerop May 2, 2023 15:31
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 2, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from dibyom after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@dibyom dibyom mentioned this pull request May 2, 2023
Closed
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.8% 0.6
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@dibyom
Copy link
Member Author

dibyom commented May 2, 2023

/restest

@dibyom dibyom marked this pull request as ready for review May 2, 2023 18:31
@tekton-robot tekton-robot requested a review from wlynch May 2, 2023 18:31
@dibyom dibyom removed request for wlynch, afrittoli and jerop May 2, 2023 18:32
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/resolution/resolver/cluster/resolver.go 84.0% 63.8% -20.2
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

dibyom added 2 commits May 3, 2023 00:21
@dibyom
Update cluster resolver to fetch v1 tasks and pipelines
027f273 
The cluster resolver used the v1beta1 pipeline client to fetch tasks and
pipelines. This meant that it always fetched the v1beta1 versions of the
resources. Since we are moving to using the reconcilers to use v1 versions of
the API, we should update the resolvers to return the v1 representations of the
tasks and pipelines from the cluster.

Note that the resolution framework itself relies on the pipeline v1beta1 API
for certain fields (Params, ConfigSource,RefSource). Migrating those is out of
scope of this commit.

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom
Revert "temporary: set default to beta"
2c3f561 
This reverts commit d214516.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following Tekton test failed:

Test name Commit Details Required Rerun command
check-pr-has-kind-label 3ae4fef link true /test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9
pkg/reconciler/pipelinerun/cancel.go 93.2% 89.8% -3.4
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.3% 0.1
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.1% 94.6% 1.5
pkg/reconciler/taskrun/resources/taskref.go 89.7% 88.8% -1.0
pkg/reconciler/taskrun/taskrun.go 85.0% 85.0% 0.0
pkg/taskrunmetrics/metrics.go 82.8% 82.0% -0.8

@tekton-robot
Copy link
Collaborator

tekton-robot commented May 3, 2023 •
edited
Loading

@dibyom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-integration-tests 3ae4fef link true /test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-beta-integration-tests 3ae4fef link true /test pull-tekton-pipeline-beta-integration-tests
pull-tekton-pipeline-alpha-integration-tests 3ae4fef link true /test pull-tekton-pipeline-alpha-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lbernick lbernick mentioned this pull request May 3, 2023
Closed
@tekton-robot
Copy link
Collaborator

@dibyom: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2023
@lbernick lbernick closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dibyom @tekton-robot @lbernick @JeromeJu