Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote the provenance field in status #6495

Merged
merged 1 commit into from
May 19, 2023
Merged

Promote the provenance field in status #6495

merged 1 commit into from
May 19, 2023

Conversation

chuangw6
Copy link
Member

@chuangw6 chuangw6 commented Apr 5, 2023 •
edited
Loading

Changes

/kind feature

Fixes #6309.

Prior, the provenance field in status was an alpha feature gated by
the dedicated feature flag named enable-provenance-in-status which is
disabled by default.

Now, we move this feature to beta by enabling this feature flag by default
with the installation of Tekton Pipelines. In future, we will completely
remove this feature flag once we feel this feature is stable.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)

Release Notes

Promote `provenance` field to beta by setting the existing feature flag `enable-provenance-in-status` to be true by default with the installation of Tekton Pipeline. This feature flag will be completely removed once we consider this as a stable feature. That said, users can choose to opt out this by setting this feature flag to false.

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 5, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 94.2% 0.8
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 88.7% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 93.3% 94.2% 0.8
pkg/reconciler/pipelinerun/pipelinerun.go 88.8% 88.7% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2023
@jerop
Copy link
Member

jerop commented Apr 12, 2023

/assign

@jerop
Copy link
Member

jerop commented Apr 24, 2023

@chuangw6 this PR needs a rebase, added it to v0.48 milestone

@chuangw6 chuangw6 force-pushed the promote-provenance-field branch from cbfccbd to 913042b Compare May 2, 2023 17:33
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9

@chuangw6 chuangw6 force-pushed the promote-provenance-field branch from 913042b to f8b7e4f Compare May 2, 2023 18:53
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@chuangw6 chuangw6 force-pushed the promote-provenance-field branch 2 times, most recently from d6aabf6 to 04601da Compare May 2, 2023 20:30
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@chuangw6 chuangw6 force-pushed the promote-provenance-field branch from 04601da to 4fafec5 Compare May 2, 2023 21:20
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@chuangw6 chuangw6 force-pushed the promote-provenance-field branch from 4fafec5 to 19e64fd Compare May 3, 2023 15:11
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 92.6% 93.5% 0.9
pkg/reconciler/pipelinerun/pipelinerun.go 89.2% 89.2% -0.0
pkg/reconciler/taskrun/taskrun.go 85.0% 84.9% -0.0

jerop
jerop requested changes May 9, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more documentation for the provenance field

It's just one sentence in: https://github.com/tektoncd/pipeline/blob/main/docs/pipelineruns.md

May be a reference to how it is populated, used in https://github.com/tektoncd/chains/tree/main/pkg/chains/formats/slsa/v2

And a note that it's now a beta feature -- also we should add it to the beta features table

@jerop
Copy link
Member

jerop commented May 9, 2023

/hold

until we clarify whether this should be guarded as a beta feature, don't want it to be made stable accidentally

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023
@chuangw6 chuangw6 force-pushed the promote-provenance-field branch from bde24b2 to c9667e9 Compare May 17, 2023 15:22
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023
@chuangw6 chuangw6 force-pushed the promote-provenance-field branch from c9667e9 to 730a722 Compare May 17, 2023 15:29
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023
@chuangw6
Copy link
Member Author

/retest

@chuangw6 chuangw6 mentioned this pull request May 18, 2023
Closed
@chuangw6
Copy link
Member Author

Thank you @jerop for the review. I've addressed all the comments. Please take a look.

Regarding the feature flag, we will keep the dedicated feature flag but enable it by default. please see the #6309 (comment) for details.

@chuangw6 chuangw6 requested a review from jerop May 18, 2023 18:44
jerop
jerop approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chuangw6!

/unhold

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
jerop
jerop reviewed May 19, 2023
View reviewed changes
docs/additional-configs.md Outdated Show resolved Hide resolved
jerop
jerop reviewed May 19, 2023
View reviewed changes
docs/additional-configs.md Outdated Show resolved Hide resolved
@chuangw6 chuangw6 force-pushed the promote-provenance-field branch 2 times, most recently from 1e611c7 to c1df06a Compare May 19, 2023 16:39
@chuangw6
Promote the provenance field in status to beta
54d9609 
Fixes tektoncd#6309.

Prior, the `provenance` field in status was an alpha feature gated by
the dedicated feature flag named `enable-provenance-in-status` which is
disabled by default.

Now, we move this feature to beta by enabling this feature flag by default
with the installation of Tekton Pipelines. In future, we will completely
remove this feature flag once we feel this feature is stable.

Signed-off-by: Chuang Wang <chuangw@google.com>
@chuangw6 chuangw6 force-pushed the promote-provenance-field branch from c1df06a to 54d9609 Compare May 19, 2023 16:39
@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@tekton-robot tekton-robot merged commit 902bee0 into tektoncd:main May 19, 2023
@EmmaMunley EmmaMunley mentioned this pull request Jun 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@chitrangpatel chitrangpatel

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.48
Development

Successfully merging this pull request may close these issues.

Promote the provenance field in *Run status
4 participants
@chuangw6 @tekton-robot @jerop @chitrangpatel