Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.44.x] Fixing CI for 0.44 (LTS) #6223

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

pritidesai
Copy link
Member

@pritidesai pritidesai commented Feb 23, 2023

Changes

0.44 is LTS release with the end of Life of 2024-01-24, until then we need to keep the CI working for it 💓

In PR #6201, we identified a failure with our CI system. Beta integrations tests are failing in PR #6201. Our CI system has been updated to run beta tests but the code base in release-v0.44.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.44.x branch for the tests to work.

Cherry picking the following PRs:

Add prow env for beta integration test #5737
Beta Example Tests #6031

This PR has these commits along with the changes after running ./hack/update-codegen.sh using Go 1.19.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

JeromeJu and others added 2 commits February 23, 2023 13:22
This PR runs example tests of beta and stable features under the feature flag
`enable-api-fields: beta`. This is an extension to PR
tektoncd#5737.
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. labels Feb 23, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2023
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2023
@pritidesai
Copy link
Member Author

diff -Naupr /home/prow/go/src/github.com/tektoncd/pipeline/vendor/modules.txt /home/prow/go/src/github.com/tektoncd/pipeline/tmpdiffroot.XQ0SS6/vendor/modules.txt
--- /home/prow/go/src/github.com/tektoncd/pipeline/vendor/modules.txt	2023-02-23 22:22:57.430816054 +0000
+++ /home/prow/go/src/github.com/tektoncd/pipeline/tmpdiffroot.XQ0SS6/vendor/modules.txt	2023-02-23 22:16:07.414201259 +0000
@@ -1657,6 +1657,7 @@ knative.dev/pkg/apis
 knative.dev/pkg/apis/duck
 knative.dev/pkg/apis/duck/ducktypes
 knative.dev/pkg/apis/duck/v1
+knative.dev/pkg/apis/duck/v1beta1
 knative.dev/pkg/changeset
 knative.dev/pkg/client/injection/apiextensions/client
 knative.dev/pkg/client/injection/apiextensions/informers/apiextensions/v1/customresourcedefinition
/home/prow/go/src/github.com/tektoncd/pipeline is out of date. Please run hack/update-codegen.sh.

Running ./hack/update-codegen.sh with the right set of dependencies does not change anything. Let's try to re-run the tests.

/retest

In PR tektoncd#6201, we identified a failure with our CI system. Beta integrations tests
are failing in PR tektoncd#6201. Our CI system has been updated to run beta tests but
the code base in release-v0.44.x was not updated with necessary changes to
run beta tests successfully. We discovered a list of PRs which needs to be
cherry picked into release-0.44.x branch for the tests to work.

Cherry picking the following PRs:

[upgrade test] Change to Kind cluster and Unfixed upgrade test release version tektoncd#5726
Add prow env for beta integration test tektoncd#5737
Beta Example Tests tektoncd#6031

Running update-codegen using Go 1.19

Signed-off-by: pritidesai <pdesai@us.ibm.com>
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@tekton-robot tekton-robot merged commit bd2109c into tektoncd:release-v0.44.x Feb 27, 2023
@pritidesai pritidesai deleted the fix-ci-for-0.44 branch February 28, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants