Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.45.x] picking up latest changes in knative 1.8 #6204

Conversation

pritidesai
Copy link
Member

@pritidesai pritidesai commented Feb 22, 2023

Changes

This PR is a result of:

go get knative.dev/pkg@release-1.8
./hack/update-codegen.sh

knative.dev/pkg was recently updated to include a performance fix which helped reduced the CPU usage by 61% and memory usage by 44% for huge pipelines. This PR is updating the tekton controllers to include that fix such that Pipelines 0.42.x can take advantage of this performance improvement.

The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was updated to use knative 1.9 post 0.45 in PR #6062.
We have another PR #6194 open to update pipeline controllers in the main branch.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Bring the latest performance fix in knative/pkg which helps reduce CPU/Memory usage for huge pipelines.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Feb 22, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2023
@tektoncd tektoncd deleted a comment from tekton-robot Feb 22, 2023
@vdemeester
Copy link
Member

@pritidesai you may need to run go mod tidy && go mod vendor I think (or ./hack/update-deps.sh that will do this and codegen)
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@pritidesai pritidesai force-pushed the bring-latest-knative-1.8-to-45 branch from c99d5c7 to cebc486 Compare February 23, 2023 21:58
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 23, 2023
@pritidesai
Copy link
Member Author

/retest

knative.dev/pkg was recently updated to include a performance fix which helped
reduced the CPU usage by 61% and memory usage by 44% for huge pipelines.
This PR is updating the tekton controllers to include that fix such that
Pipelines 0.42.x can take advantage of this performance improvement.

The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was
updated to use knative 1.9 post 0.45 in PR tektoncd#6062.
We have another PR tektoncd#6194 open to update pipeline controllers in the main branch.

Signed-off-by: pritidesai <pdesai@us.ibm.com>
@pritidesai pritidesai force-pushed the bring-latest-knative-1.8-to-45 branch from cebc486 to b5796c6 Compare March 20, 2023 21:15
@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@tekton-robot tekton-robot merged commit 5314ca2 into tektoncd:release-v0.45.x Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants