matrix with array results indexing #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While an array cannot be feed into matrix param directly using the start notation, it is possible to index into an array results. Updating an existing example to include that usuage. Signed-off-by: pritidesai <pdesai@us.ibm.com>
|
I mentioned as a comment in one of the PRs that array indexing is not yet supported in matrix - see #6055 (comment) I will take it back, this PR does showcase indexing into an array is permitted as a matrix param. But referencing the whole array is not yet supported. /cc @jerop |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
afrittoli
reviewed
Jan 31, 2023
|
/retest |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While an array cannot be feed into matrix param directly using the start notation, it is possible to index into an array results. Updating an existing example to showcase that usage. I will update the doc in a follow up PR.
Signed-off-by: pritidesai pdesai@us.ibm.com
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes