-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix converted legacy bundle->remote resolver syntax to be case-insensitive for kind #6061
Fix converted legacy bundle->remote resolver syntax to be case-insensitive for kind #6061
Conversation
/assign @afrittoli @chuangw6 @JeromeJu |
@abayer: GitHub didn't allow me to assign the following users: JeromeJu. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…itive for kind fixes tektoncd#6058 When we finished deprecating the legacy bundle resolution syntax, we recommended users change from: ``` taskRef: name: git-batch-merge bundle: gcr.io/tekton-releases/catalog/upstream/git-batch-merge:0.2 ``` to ``` taskRef: resolver: bundles params: - name: bundle value: gcr.io/tekton-releases/catalog/upstream/git-batch-merge:0.2 - name: name value: git-batch-merge - name: kind value: Task ``` But that created a problem - we have been comparing the `kind` parameter to the `dev.tekton.image.kind` annotation value in the bundle, which is generally all lower-case. Since we generally use `Task`, `Pipeline`, etc for `kind` values in our syntax, we've created a situation where the "normal" way to specify a `kind`, i.e., capitalized, is not going to work for most, if not all, bundles. To fix this, we're changing the check in the remote bundles resolver to do a case-insensitive comparison. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
659fb04
to
cddc1c6
Compare
LTGM just one last nit will it be helpful to also include this 'notice' at https://github.com/tektoncd/pipeline/blob/main/docs/bundle-resolver.md? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check-pr-has-kind-label |
@abayer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
fixes #6058
When we finished deprecating the legacy bundle resolution syntax, we recommended users change from:
to
But that created a problem - we have been comparing the
kind
parameter to thedev.tekton.image.kind
annotation value in the bundle, which is generally all lower-case. Since we generally useTask
,Pipeline
, etc forkind
values in our syntax, we've created a situation where the "normal" way to specify akind
, i.e., capitalized, is not going to work for most, if not all, bundles.To fix this, we're changing the check in the remote bundles resolver to do a case-insensitive comparison.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes