-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating an example pipelinerun with array indexing #6060
updating an example pipelinerun with array indexing #6060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pritidesai !
I gave it a try and figured out that the PipelineRun
failed because its child TaskRun failed to substitue the environment variable 🤔 Not sure why does that happen.
TaskRun "step-echo-params-1" exited with code 1 (image: "docker.io/library/bash@sha256:46aef8866a15877c36cf72736f1433e827c648d27dfcc9f1c1f187e8df762be9"); for logs run: kubectl -n default logs pipelinerun-param-array-indexing-c8jkb-deploy-pod -c step-echo-params-1
> kubectl -n default logs pipelinerun-param-array-indexing-c8jkb-deploy-pod -c step-echo-params-1
failed to validate the one and only argument of the script
Want: staging, Got: $(params.environments[0])
It seems to be a bug, created an issue #6066 to track it. |
Could you check if you have enabled alpha feature flag? I can get the same error if not enabled. |
examples/v1beta1/pipelineruns/alpha/pipelinerun-param-array-indexing.yaml
Show resolved
Hide resolved
Thanks @XinruZhang and @Yongxuanzhang. Yeah its misleading, we could do a little better at handling this - I have created an issue -#6102 - addressing a similar behavior, using alpha feature without enabling alpha flag. |
Validating the expected param values while indexing into an array when task array params mapped to a pipeline array params and task string params are an elements of a pipeline array param Signed-off-by: pritidesai <pdesai@us.ibm.com>
fe28cd7
to
7bfd19f
Compare
/lgtm |
Thank you @pritidesai ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hope I can approve 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @pritidesai!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This is for the preparation of a potential promotion of #5688.
Signed-off-by: pritidesai pdesai@us.ibm.com
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes