Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagated Workspaces to Beta #6030

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Propagated Workspaces to Beta #6030

merged 1 commit into from
Jan 31, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Jan 24, 2023 •
edited
Loading

[Issue 5505] Migrate Propagated Workspaces to Beta

Prior to this, propagated workspaces was hidden behind the alpha feature gate.
This feature is now enabled if the feature flag enable-api-field is alpha or beta.

Changes

  • Updated feature flag FeatureFlags.EnableAPIFields check from alpha to not stable.
  • Moved examples from alpha to beta folder.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The feature propagated workspaces is now enabled if the feature flag, enable-api-field value is set to alpha or beta.

/kind feature

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 24, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2023
@chitrangpatel
Copy link
Contributor Author

/assign @jerop

@chitrangpatel
Copy link
Contributor Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor Author

/test pull-tekton-pipeline-unit-tests

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor Author

/test tekton-pipeline-unit-tests

@chitrangpatel
Copy link
Contributor Author

/hold wait till #6031 is merged

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2023
@chitrangpatel chitrangpatel force-pushed the propagated-workspaces-beta branch from 13ba177 to 5005684 Compare January 27, 2023 15:57
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2023
jerop
jerop reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @chitrangpatel!

docs/pipelineruns.md Outdated Show resolved Hide resolved
docs/taskruns.md Outdated Show resolved Hide resolved
pkg/reconciler/pipelinerun/pipelinerun.go Show resolved Hide resolved
@chitrangpatel chitrangpatel force-pushed the propagated-workspaces-beta branch 2 times, most recently from 72fd104 to 1264120 Compare January 30, 2023 18:11
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2023
@chitrangpatel
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2023
@chitrangpatel
Copy link
Contributor Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor Author

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerop
jerop reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chitrangpatel please update the commit message and PR description with further details: https://github.com/tektoncd/community/blob/main/standards.md#commits

And release notes too: https://github.com/tektoncd/community/blob/main/standards.md#release-notes

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@jerop
Copy link
Member

jerop commented Jan 31, 2023

/hold

commit message needs to be updated

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
@chitrangpatel
This PR migrates the feature, Propagated Workspaces to Beta as per Is…
3183cb3 
…sue tektoncd#5505. No updates were made to the functionality of this feature except updating the feature flag FeatureFlags.EnableAPIFields check from alpha to not stable (meaning that it will only be enabled if the feature flag enable-api-field is alpha or beta).
@chitrangpatel chitrangpatel force-pushed the propagated-workspaces-beta branch from 1264120 to 3183cb3 Compare January 31, 2023 14:52
@chitrangpatel
Copy link
Contributor Author

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerop
jerop reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@jerop
Copy link
Member

jerop commented Jan 31, 2023

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
@chitrangpatel
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot merged commit 3dafa81 into tektoncd:main Jan 31, 2023
@jerop jerop mentioned this pull request Feb 3, 2023
Closed
@pritidesai pritidesai mentioned this pull request Feb 14, 2023
Merged
7 tasks
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this pull request Feb 14, 2023
@chitrangpatel
Move Propagated Workspaces to list of beta features
8b9e798 
Prior to this, Propagated Workspaces was left under the
list of alpha features. It was promoted to beta in PR
tektoncd#6030. This PR
moves it to the list of beta features in the documentation.
@chitrangpatel chitrangpatel mentioned this pull request Feb 14, 2023
Merged
7 tasks
tekton-robot pushed a commit that referenced this pull request Feb 14, 2023
@chitrangpatel @tekton-robot
Move Propagated Workspaces to list of beta features
62e808b 
Prior to this, Propagated Workspaces was left under the
list of alpha features. It was promoted to beta in PR
#6030. This PR
moves it to the list of beta features in the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@jerop jerop jerop left review comments

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chitrangpatel @tekton-robot @jerop @vdemeester @Yongxuanzhang