Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint in Makefile and tools/go.mod to v1.50.1 #5935

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Jan 3, 2023

Changes

We've changed to using golangci-lint v1.50.1 in CI, and have added new configured linters that aren't available in the older v1.47.2 which we have been using in Makefile and tools/go.mod, so let's update those places accordingly.

I noticed this when I ran make golangci-lint locally and the old version was built/used and I got an error message about missing linters. =)

cc @bendory

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

We've changed to using golangci-lint v1.50.1 in CI, and have added new configured linters that aren't available in the older v1.47.2 which we have been using in `Makefile` and `tools/go.mod`, so let's update those places accordingly.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 3, 2023
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@bendory
Copy link
Contributor

bendory commented Jan 3, 2023

Thank you for cleaning this up!

Ref: #5899

@bendory
Copy link
Contributor

bendory commented Jan 3, 2023

/lgtm
even if the robot doesn't like me yet :-(

@tekton-robot
Copy link
Collaborator

@bendory: changing LGTM is restricted to collaborators

In response to this:

/lgtm
even if the robot doesn't like me yet :-(

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@tekton-robot tekton-robot merged commit e263924 into tektoncd:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants