Add integration upgrade test on older version

[JeromeJu]

Changes

This commit adds the integration test on older version to prevent regression of current changes.

To prove that this PR could catch the regression:

• Reproducing Regression: PipelineTaskRunSpec.Metadata incompatible with older webhooks #4913 and catch it with the existing change.
• Remove the pointer expression of pipelineRunSpec.taskRunSpecs.metadata.
• The previous version is set to the release version (v0.35.1) before the PR that introduces the regression.

Test case for regression:

• tested at https://github.com/JeromeJu/pipeline/tree/upgrade-regression-test
• Change ./test/e2e-tests-upgrade to install the previous version of Regression: PipelineTaskRunSpec.Metadata incompatible with older webhooks #4913.
• run ./test/e2e-tests-upgrade.sh, expect

serviceaccount_test.go:163: Failed to create PipelineRun `pipeline-run-with-service-accounts-xtlybuvy`: admission webhook "webhook.pipeline.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "metadata"

/kind misc
fixes: #5782 case i

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [n/a] Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[JeromeJu]

Actually it worked (the upgrade test failed and caught it). Just that the logs are not easy to find. But essentially the UI could be better in prow.

Current status:

• Trying to catch the regression of Regression: PipelineTaskRunSpec.Metadata incompatible with older webhooks #4913 as an example.
• Reverting fixes https://github.com/tektoncd/pipeline/pull/4914/files to test if this shall be catched.

Findings: didn't catch the expected error. Adding the example tests. Trying to figure out how to replicate the following steps in test:

Install Tekton < #4834
Create PipelineRun using client >= #4834

Thanks to the pointers from @austinzhao-go , the https://github.com/tektoncd/pipeline/blob/main/test/serviceaccount_test.go#L160 should have caught this.

[lbernick]

/test check-pr-has-kind-label

[tekton-robot]

@lbernick: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-tekton-pipeline-alpha-integration-tests
• /test pull-tekton-pipeline-build-tests
• /test pull-tekton-pipeline-integration-tests
• /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

• /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from lbernick after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JeromeJu]

Updated the test case to prove this workable, and test case updated at https://github.com/JeromeJu/pipeline/tree/upgrade-regression-test. PTAL @lbernick 🙏

[afrittoli]

It would be nice to update the initial comments (lines 21+) and describe what this script aims to test.

If I read this correctly, what you are doing here is to running the tests from main against the latest release of Tekton.
Unless tests are smart enough to skip themselves if a feature they rely on is not available, this test has a good chance of failing.

What we might consider doing is to run the tests from the latest release against main, which would ensure that no backward incompatible change was done.
Since there are cases where we do backward incompatible changes (in alpha and beta API versions, after the deprecation period), in these few cases we would have to call this out specifically in the tests, for instance we could have a mechanism to tell the tests to skip if the version of the target Tekton installation is greater than a certain value.

This would still require to go backk and update the tests from the released versions though. An alternative could be to maintain in this script a version dependent exclusion list, to be passed to the go test command, with comments explaining the reason for the skip.

[vdemeester]

Note that we don't necessarily need to run all the test in the old "released" version 👼🏼. We just need to run enough testing to make sure it works (because ideally it runs a released version, that should have had all its own test run and successful when we released), upgrade and run the main test on the upgraded instance to make sure it behave as intended. So we could have a "light", relatively safe, test suite for that part.

[tekton-robot]

@JeromeJu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-pipeline-integration-tests	74cbae5	link	true	/test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-beta-integration-tests	74cbae5	link	true	/test pull-tekton-pipeline-beta-integration-tests
pull-tekton-pipeline-alpha-integration-tests	74cbae5	link	true	/test pull-tekton-pipeline-alpha-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.