-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WebHook controller crashing on minishift #572
Fix WebHook controller crashing on minishift #572
Conversation
Installing tekton on minishift fails to bring up webhook-controller pod due missing RBAC policy. Pod logs shows the following error ``` json { "level":"error", "logger":"webhook", "caller":"webhook/webhook.go:310" , "msg":"failed to register webhook" "knative.dev/controller":"webhook" "error":"failed to create a webhook: mutatingwebhookconfigurations.admissionregistration.k8s.io \"webhook.tekton.dev\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: no RBAC policy matched " "stacktrace":" github.com/knative/build-pipeline/vendor/github.com/knative/pkg/webhook.(*AdmissionController).Run /usr/local/google/home/jasonhall/go/src/github.com/knative/build-pipeline/vendor/github.com/knative/pkg/webhook/webhook.go:310 main.main /usr/local/google/home/jasonhall/go/src/github.com/knative/build-pipeline/cmd/webhook/main.go:97" } ``` This patch fixes it by adding the missing rules for `deployments/finailizer` resource to the cluster-role.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/assign vdemeester |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shashwathi, sthaha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(note @sthaha I updated your release note!) |
Thank you! If you could point me at the commit, I will have release notes updated as well next time I submit a patch. |
Installing tekton on minishift fails to bring up webhook-controller pod
due missing RBAC policy. Pod logs shows the following error
This patch fixes it by adding the missing rules for
deployments/finailizer
resource to the cluster-role.Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes