feat: support to extract init container failure message #5646
Conversation
|
|
|
Hi @cugykw. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7dd0b03 to
1cd90f4
Compare
|
/kind bug |
|
/kind feature |
|
/kind bug |
|
/kind feature |
|
/test check-pr-has-kind-label |
|
@abayer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/pod/status.go
Outdated
| return fmt.Sprintf("init container failed, %s", msg) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we want to move this code block before surfacing actual build step errors? As the init container runs before those actual build steps?
There was a problem hiding this comment.
Do we want to move this code block before surfacing actual build step errors? As the init container runs before those actual build steps?
good idea. i have adjusted.
|
/test check-pr-has-kind-label |
|
@XinruZhang: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/test check-pr-has-kind-label |
|
@abayer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The following is the coverage report on the affected files.
|
|
/retest |
1 similar comment
|
/retest |
1cd90f4 to
620b1ba
Compare
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
fixes #5645 |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/retest |
When the pod fails to run, taksrun additionally obtains the init container status to display the error message.
Changes
Now, when an error occurs in the init container, the taskrun clearly displays the error message.
Fixs: #5645
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes