Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git-resolver/PipelineTask example to tests #5604

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add git-resolver/PipelineTask example to tests #5604

merged 1 commit into from
Oct 10, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Oct 5, 2022 •
edited
Loading

Changes

This uses /task/git-clone/0.7/git-clone.yaml on main in the Catalog repo as the remote task.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@abayer abayer added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 5, 2022
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 5, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2022
@abayer
Copy link
Contributor Author

abayer commented Oct 5, 2022

/assign @afrittoli @lbernick @vdemeester

@abayer abayer mentioned this pull request Oct 5, 2022
Merged
7 tasks
@abayer
Copy link
Contributor Author

abayer commented Oct 5, 2022

/retest

Hmm. The test passes for me locally - I'm going to rerun it once to see if anything's different.

@abayer
Copy link
Contributor Author

abayer commented Oct 5, 2022

Ok, still failing. Something else is going on, not sure what - I'll get back to this later.

@abayer
Copy link
Contributor Author

abayer commented Oct 5, 2022

/hold

Holding while I do some debug logging.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@abayer
Copy link
Contributor Author

abayer commented Oct 5, 2022

/retest

Yongxuanzhang
Yongxuanzhang reviewed Oct 5, 2022
View reviewed changes
examples/v1beta1/pipelineruns/alpha/git-resolver.yaml Outdated
Comment on lines 31 to 32
params:
params:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicate? And cause err:

  31:16     error    empty value in block mapping  (empty-values)
  32:9      error    duplication of key "params" in mapping  (key-duplicates)

@abayer
Copy link
Contributor Author

abayer commented Oct 5, 2022

/retest
/hold cancel

Ok, so for some reason, using test/git-resolver/remote-task.yaml doesn't work in CI, but using a task from the catalog's git repo does work, so hey, let's just use that instead.

@abayer abayer force-pushed the example-yaml-pipelinetask-git-resolver branch from e901094 to e51bb14 Compare October 5, 2022 15:00
@afrittoli
Copy link
Member

/retest

@afrittoli afrittoli closed this Oct 5, 2022
@afrittoli afrittoli reopened this Oct 5, 2022
@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@abayer abayer force-pushed the example-yaml-pipelinetask-git-resolver branch from e51bb14 to 6be77ba Compare October 5, 2022 15:43
@abayer
Add git-resolver/PipelineTask example to tests
491c120 
This uses `/task/git-clone/0.7/git-clone.yaml` in the Catalog repo as the remote task.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer force-pushed the example-yaml-pipelinetask-git-resolver branch from 6be77ba to 491c120 Compare October 5, 2022 16:27
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
vdemeester
vdemeester approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit ed8343d into tektoncd:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@dibyom dibyom dibyom approved these changes

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@vdemeester vdemeester

@afrittoli afrittoli

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abayer @afrittoli @tekton-robot @vdemeester @dibyom @Yongxuanzhang @lbernick