Update go.mod to go 1.18 #5338
Merged
Update go.mod to go 1.18 #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @vdemeester @imjasonh |
vdemeester
approved these changes
Aug 18, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e68b656 to
6dd4eb1
Compare
This isn't strictly necessary - the go 1.18 and 1.17 semantics for `go.mod` are the same - but in practice, I find that people often look at `go.mod` to see what version of Go they need to build something, and, well, we need 1.18 now. So might as well update this! Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
6dd4eb1 to
83a0296
Compare
|
/lgtm |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This isn't strictly necessary - the go 1.18 and 1.17 semantics for
go.modare the same - but in practice, I find that people often look atgo.modto see what version of Go they need to build something, and, well, we need 1.18 now. So might as well update this!btw, the 1.18 requirement came in with #5311.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes