[0.38: cherry-pick] Use step.ImageID instead of looking into status.TaskSpec #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tr.Status.TaskSpec.Steps` can be out-of-sync with `tr.Status.Steps`. As we already have the image information (through `ImageID`) in the struct be are getting from our iteration, we don't need to look into another array, with the risk of getting a panic. The same goes for sidecars. We managed to get multiple panics on the controller prior to this change. See tektoncd#4952 for the initial implementation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
|
/kind bug |
|
The following is the coverage report on the affected files.
|
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tr.Status.TaskSpec.Stepscan be out-of-sync withtr.Status.Steps. As we already have the image information (throughImageID) in the struct be are getting from our iteration, we don'tneed to look into another array, with the risk of getting a panic.
The same goes for sidecars.
We managed to get multiple panics on the controller prior to this change.
See #4952 for the initial implementation.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes