Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TerminationMessagePolicy in container conversion #5201

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

lbernick
Copy link
Member

Changes

The "TerminationMessagePolicy" field for v1beta1 Step, StepTemplate,
and Sidecar, and v1 Sidecar, should be used when converting to and from
the Kubernetes container struct. They were omitted by accident, and
this commit adds them in.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[Bug fix] Apply the TerminationMessagePolicy field for container types

The "TerminationMessagePolicy" field for v1beta1 Step, StepTemplate,
and Sidecar, and v1 Sidecar, should be used when converting to and from
the Kubernetes container struct. They were omitted by accident, and
this commit adds them in.
@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 22, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_types.go 29.8% 29.2% -0.6
pkg/apis/pipeline/v1beta1/container_types.go 34.8% 34.8% -0.1

@lbernick
Copy link
Member Author

integration tests failed on TestPipelineRunTimeout (known flake)
unit tests failed w/ TestRealRunnerStdoutAndStderr (known flake)

/retest

@dibyom
Copy link
Member

dibyom commented Jul 22, 2022

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@dibyom: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lbernick lbernick mentioned this pull request Jul 22, 2022
4 tasks
@abayer
Copy link
Contributor

abayer commented Jul 22, 2022

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Do we need to backport this ?

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 3f53972 into tektoncd:main Jul 25, 2022
@lbernick
Copy link
Member Author

Do we need to backport this ?

Maybe? This bug causes the TerminationMessagePolicy to not work but I'm not sure anyone is actually using this. Better safe than sorry I guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants