-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TerminationMessagePolicy in container conversion #5201
Conversation
The "TerminationMessagePolicy" field for v1beta1 Step, StepTemplate, and Sidecar, and v1 Sidecar, should be used when converting to and from the Kubernetes container struct. They were omitted by accident, and this commit adds them in.
The following is the coverage report on the affected files.
|
integration tests failed on TestPipelineRunTimeout (known flake) /retest |
/test check-pr-has-kind-label |
@dibyom: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Do we need to backport this ?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Maybe? This bug causes the TerminationMessagePolicy to not work but I'm not sure anyone is actually using this. Better safe than sorry I guess? |
Changes
The "TerminationMessagePolicy" field for v1beta1 Step, StepTemplate,
and Sidecar, and v1 Sidecar, should be used when converting to and from
the Kubernetes container struct. They were omitted by accident, and
this commit adds them in.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes