Allow PipelineTaskRunSpec.Metadata to be optional. #4914
Conversation
Previously, this was using a non-pointer value, which means that the field was not actually optional and was being included in client requests. If this request was sent to an older server, this would break during unmarshalling because the field doesn't exist yet for older servers. This changes the type to use a pointer so it will actually be omitted in newer clients if it is not set. Co-authored-by: Scott Nichols <n3wscott@chainguard.dev> Signed-off-by: Billy Lynch <billy@chainguard.dev>
|
/assign @austinzhao-go |
|
@wlynch: GitHub didn't allow me to assign the following users: austinzhao-go. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @austinzhao-go |
|
@wlynch: GitHub didn't allow me to request PR reviews from the following users: austinzhao-go. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The following is the coverage report on the affected files.
|
|
/cc @jerop |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
|
/test pull-tekton-pipeline-alpha-integration-tests pull-tekton-pipeline-integration-tests |
Changes
Previously, this was using a non-pointer value, which means that the
field was not actually optional and was being included in client
requests. If this request was sent to an older server, this would break
during unmarshalling because the field doesn't exist yet for older
servers.
This changes the type to use a pointer so it will actually be omitted in
newer clients if it is not set.
Co-authored-by: Scott Nichols n3wscott@chainguard.dev
Signed-off-by: Billy Lynch billy@chainguard.dev
/kind bug
Fixes #4913
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes