Add log line to debg workspace-in-sidecar example #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the workspace-in-sidecar example didn't print anything before creating a fifo file in its first Step. When the example fails we are missing information here that would be useful to debug whether the Step ever started or is blocking on that `mkfifo` call. This commit adds the log line we need to debug whether the Step ever starts.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this commit the workspace-in-sidecar example didn't print anything before creating a fifo file in its first Step. When the example fails we are missing information here that would be useful to debug whether the Step ever started or is blocking on that
mkfifocall.This commit adds the log line we need to debug whether the Step ever starts. More info available at #4169
/kind flake
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes