workspace-in-sidecar flakey test fix #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the sizeLimit could be causing the eviction manager to trigger a pod eviction, causing flakey tests
|
/test pull-tekton-pipeline-integration-tests |
|
/test pull-tekton-pipeline-integration-tests |
|
/retest |
|
/lgtm |
pritidesai
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
thank you @xchapter7x 👍
I have updated the PR description to include none release notes!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is super cool! I'm very excited to see if the 🐛 is finally squashed - I've definitely learned something :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for the flakes in workspace-in-sidecar tests
Changes
This change re-adds the flakey workspace-in-sidecar tests, with changes.
The changes remove the sizeLimit on the emptyDir, which could be a reason the tests would fail, as the limit was rather low and would cause a POD eviction.
#4169
/kind flake
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes