Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for some arm64 machines. #4588

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix for some arm64 machines. #4588

merged 1 commit into from
Feb 17, 2022

Conversation

MrMYHuang
Copy link
Contributor

@MrMYHuang MrMYHuang commented Feb 16, 2022 •
edited
Loading

Changes

As said in GoogleContainerTools/distroless#657, in the past, distroless/base:debug used an arm32 busybox binary in its arm64 image. Which doesn't work on some arm64 machines, e.g., Ubuntu 21 arm64 on Parallels Desktop on Apple Silicon M1. It caused this error:

$ docker run -it gcr.io/distroless/base@sha256:cfdc553400d41b47fd231b028403469811fcdbc0e69d66ea8030c5a0b5fbac2b
standard_init_linux.go:228: exec user process caused: exec format error

Fortunately, this PR GoogleContainerTools/distroless#960 fixes this bug. Hence, I update the distroless/base:debug used by Tekton Pipeline in this commit.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Fix problems on some arm64 machines.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 16, 2022
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2022
@tekton-robot
Copy link
Collaborator

Hi @MrMYHuang. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MrMYHuang
Copy link
Contributor Author

/ok-to-test

@tekton-robot
Copy link
Collaborator

@MrMYHuang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai
Copy link
Member

thank you @MrMYHuang 👍 Welcome to the community!

/ok-to-test
/cc @afrittoli @imjasonh

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
imjasonh
imjasonh reviewed Feb 16, 2022
View reviewed changes
config/controller.yaml Outdated Show resolved Hide resolved
jerop
jerop approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @MrMYHuang 🎉

Thank you for the detailed PR description, can you please copy over those details to the commit message as well?

https://github.com/tektoncd/community/blob/main/standards.md#commits

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imjasonh, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afrittoli
Copy link
Member

@MrMYHuang Thank you! This could be merged in time for v0.33 (tomorrow). Would you mind updating the commit message so we can merge it?

@MrMYHuang
Copy link
Contributor Author

Welcome @MrMYHuang 🎉

Thank you for the detailed PR description, can you please copy over those details to the commit message as well?

https://github.com/tektoncd/community/blob/main/standards.md#commits

Yes. Please see 8d88b18. Thank you.

@MrMYHuang
Copy link
Contributor Author

@MrMYHuang Thank you! This could be merged in time for v0.33 (tomorrow). Would you mind updating the commit message so we can merge it?

Yes. Please see 8d88b18. Thank you.

@pritidesai
Copy link
Member

@MrMYHuang please squash the commits into one, let me know if you need squashing both of your commits into one.

@MrMYHuang
Fix for some arm64 machines.
6d93184 
As said in GoogleContainerTools/distroless#657, in the past, distroless/base:debug used an arm32 busybox binary in its arm64 image. Which doesn't work on some arm64 machines, e.g., Ubuntu 21 arm64 on Parallel Desktop on Apple Silicon M1. It caused this error:
"
$ docker run -it gcr.io/distroless/base@sha256:cfdc553400d41b47fd231b028403469811fcdbc0e69d66ea8030c5a0b5fbac2b
standard_init_linux.go:228: exec user process caused: exec format error
"

This PR GoogleContainerTools/distroless#960 fixes this bug. Hence, update the distroless/base:debug used by Tekton Pipeline in this commit.
@MrMYHuang
Copy link
Contributor Author

@MrMYHuang please squash the commits into one, let me know if you need squashing both of your commits into one.

Is this commit 6d93184 ok?

@pritidesai
Copy link
Member

yup works great 👍
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
@MrMYHuang MrMYHuang changed the title Fix for arm64 machines. Fix for some arm64 machines. Feb 17, 2022
@tekton-robot tekton-robot merged commit b6d21ed into tektoncd:main Feb 17, 2022
@MrMYHuang
Copy link
Contributor Author

Thanks for everyone! Pipeline v0.33 works well on Ubuntu 21 arm64 on Parallels Desktop on MacBook Air 2020 M1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

@jerop jerop jerop approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MrMYHuang @tekton-robot @pritidesai @afrittoli @imjasonh @jerop