-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore variant when looking up command for platform in entrypoint #4550
Conversation
@vaikas If you could try this out and see if it fixes your bug that'd be helpful. If not, I have another idea but it's a bit more involved than this. |
The following is the coverage report on the affected files.
|
1e66332
to
30d43e7
Compare
The following is the coverage report on the affected files.
|
30d43e7
to
53699ec
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
This change changes our runtime platform selection logic to allow matching platforms that don't match the CPU variant, since some indexes only provide the variant-less platform, and should be chosen in that case rather than failing. If the platform's command is found including the CPU variant, it will be used. If not, we'll also check if there's a variant-less platform that matches, and if so, we'll use that command.
53699ec
to
ed1ffa5
Compare
The following is the coverage report on the affected files.
|
Thanks @imjasonh works fantastic with this change!!! |
/approve Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes #4548
/kind bug
This change changes our runtime platform selection logic to allow matching platforms that don't match the CPU variant, since some indexes only provide the variant-less platform, and should be chosen in that case rather than failing.
If the platform's command is found including the CPU variant, it will be used. If not, we'll also check if there's a variant-less platform that matches, and if so, we'll use that command.
cc @vaikas
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes