Account for PipelineRun elapsed time for timeouts #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the `getTaskRunTimeout` function returned a timeout for a new TaskRun with the assumption that the new TaskRun started at the same time that the PipelineRun started. This led to `pipelinerun.timeouts.tasks` being ignored by TaskRun retries or sequential TaskRuns. `pipelinerun.timeouts.finally` has the same problem for retries of finally tasks, but does not have the same problem for multiple separate finally tasks because finally tasks run in parallel. This commit subtracts time that has already been elapsed in the pipelineRun from `pipelinerun.timeouts.tasks` when creating a new TaskRun. The relationship between finally timeout and retries will be addressed in a separate commit. Co-authored-by: Jerop Kipruto jerop@google.com
vdemeester
approved these changes
Jan 24, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
5 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this change, the
getTaskRunTimeoutfunction returned a timeout for a new TaskRunwith the assumption that the new TaskRun started at the same time that the PipelineRun started.
This led to
pipelinerun.timeouts.tasksbeing ignored by TaskRun retries or sequential TaskRuns (#4071).pipelinerun.timeouts.finallyhas the same problem for retries of finally tasks, but does not have the sameproblem for multiple separate finally tasks because finally tasks run in parallel.
This commit subtracts time that has already been elapsed in the pipelineRun from
pipelinerun.timeouts.taskswhen creating a new TaskRun. The relationship between finally timeout and retries will be addressed in a separate commit.
Co-authored-by: Jerop Kipruto jerop@google.com @jerop
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes