Revert 49a7fa to remove fake AWS creds #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested the changes @imjasonh made in adf030 without these fake aws credentials and it does appear that the ten minutes slow down we were observing in #4087 are fixed. This PR backs out the phony AWS creds that were in place on the controller to work around long delays on initial image fetches for entrypoint lookup (and bundles) related to k8schain.
vdemeester
approved these changes
Jan 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I tested the changes @imjasonh made in adf030 without these fake aws
credentials and it does appear that the ten minute slow down we were
observing in #4087 is fixed.
This PR backs out the phony AWS creds that were in place on the
controller to work around long delays on initial image fetches for
entrypoint lookup (and bundles) related to k8schain.
Closes #4087
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes