-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect format specifier in test files #4495
Conversation
I wonder if I should open an issue and link it to this PR in our pipeline repo? |
/lgtm Seems fine without an issue to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, thank you @Yongxuanzhang 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Prior to this commit the unit tests of remote_test.go will fail in Go 1.18.
error log:
Related issues:
This commit converts all the %w in remote_test.go to %v to fix failing tests.
Please let me know if this makes sense or you have better ideas. Thanks in advance!
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes