Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect format specifier in test files #4495

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Jan 18, 2022

Changes

Prior to this commit the unit tests of remote_test.go will fail in Go 1.18.
error log:

# github.com/tektoncd/pipeline/test
test/remote_test.go:50:3: (*testing.common).Errorf does not support error-wrapping directive %w
test/remote_test.go:56:3: (*testing.common).Errorf does not support error-wrapping directive %w
test/remote_test.go:61:3: (*testing.common).Errorf does not support error-wrapping directive %w
test/remote_test.go:66:3: (*testing.common).Errorf does not support error-wrapping directive %w
test/remote_test.go:71:3: (*testing.common).Errorf does not support error-wrapping directive %w
test/remote_test.go:87:3: (*testing.common).Errorf does not support error-wrapping directive %w
test/remote_test.go:94:3: (*testing.common).Errorf does not support error-wrapping directive %w
test/remote_test.go:99:3: (*testing.common).Errorf does not support error-wrapping directive %w

FAIL    github.com/tektoncd/pipeline/test [build failed]

Related issues:

This commit converts all the %w in remote_test.go to %v to fix failing tests.

Please let me know if this makes sense or you have better ideas. Thanks in advance!

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 18, 2022
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 18, 2022
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review January 18, 2022 21:08
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2022
@Yongxuanzhang
Copy link
Member Author

I wonder if I should open an issue and link it to this PR in our pipeline repo?

@abayer
Copy link
Contributor

abayer commented Jan 18, 2022

/lgtm

Seems fine without an issue to me!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, thank you @Yongxuanzhang 👍

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@tekton-robot tekton-robot merged commit 863ae57 into tektoncd:main Jan 18, 2022
@afrittoli afrittoli added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants