Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop minishift instructions #4489

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Drop minishift instructions #4489

merged 1 commit into from
Jan 20, 2022

Conversation

concaf
Copy link
Contributor

@concaf concaf commented Jan 16, 2022

Changes

This commit drops instructions for minishift since it's not in active development anymore and has been replaced by CRC which does not need any specific instructions. See https://github.com/minishift/minishift#welcome-to-minishift.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)
NONE

ping @vdemeester, WDYT?

This commit drops instructions for minishift since it's not in active development anymore and has been replaced by CRC which does not need any specific instructions. See https://github.com/minishift/minishift#welcome-to-minishift.
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. labels Jan 16, 2022
@tekton-robot tekton-robot requested review from dlorenc and jerop January 16, 2022 12:38
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2022
@concaf
Copy link
Contributor Author

concaf commented Jan 16, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022
@pritidesai
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@ghost
Copy link

ghost commented Jan 19, 2022

The alpha integration failed on common flake test/v1alpha1 TestSidecarTaskSupport/A_sidecar_that_runs_forever_is_terminated_when_Steps_complete 1m6s

/test pull-tekton-pipeline-alpha-integration-tests

@ghost
Copy link

ghost commented Jan 19, 2022

/lgtm

@tekton-robot tekton-robot assigned ghost Jan 19, 2022
@abayer
Copy link
Contributor

abayer commented Jan 19, 2022

Closing and reopening to hopefully unjam EasyCLA.

@abayer abayer closed this Jan 19, 2022
@abayer abayer reopened this Jan 19, 2022
@abayer
Copy link
Contributor

abayer commented Jan 19, 2022

/retest

@pritidesai
Copy link
Member

/test pull-tekton-pipeline-integration-tests

1 similar comment
@concaf
Copy link
Contributor Author

concaf commented Jan 20, 2022

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit e752c2f into tektoncd:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants