Support workingDir init on Windows #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following is the coverage report on the affected files.
|
be680d9 to
2281e25
Compare
vdemeester
approved these changes
Jan 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Very nice, cheers! /lgtm |
Previously, we used --shell-image (typically distroless/base) to invoke `mkdir -p <dirs>` to initialize any working dirs that were needed by steps in a TaskRun. This isn't portable to Windows, since distroless/base doesn't provide Windows images, and since invoking `mkdir -p` won't work on Windows. Instead, with this change, we init working dirs using a very simple Go binary that can be cross-compiled to run on both OSes.
2281e25 to
ce42596
Compare
|
/lgtm |
This was referenced Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used --shell-image (typically distroless/base) to invoke
mkdir -p <dirs>to initialize any working dirs that were needed bysteps in a TaskRun.
This isn't portable to Windows, since distroless/base doesn't provide
Windows images, and since invoking
mkdir -pwon't work on Windows.Instead, with this change, we init working dirs using a very simple Go
binary that can be cross-compiled to run on both OSes.
Fixes #4473
cc @lippertmarkus
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes