Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge default PodTemplate's affinity field #4406

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

devholic
Copy link

@devholic devholic commented Dec 6, 2021

Changes

Currently, default PodTemplate's affinity field is ignored since mergePodTemplateWithDefault doesn't merge affinity field.

This PR will merge default PodTemplate's affinity field.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

  • Bug fixes
Fixes an issue that default PodTemplate's affinity field is ignored.

Currently, default PodTemplate's affinity field is ignored since
`mergePodTemplateWithDefault` doesn't merge `affinity` field.

Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Dec 6, 2021
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2021
@tekton-robot
Copy link
Collaborator

Hi @devholic. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imjasonh
Copy link
Member

imjasonh commented Dec 6, 2021

/ok-to-test

Is there a docs update we need to make corresponding to this change?

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2021
@devholic
Copy link
Author

devholic commented Dec 7, 2021

@imjasonh

Is there a docs update we need to make corresponding to this change?

I think we don't have to update document since it is mentioned in Pod templates document 🙂

You also have the option to define a global Pod template in your Tekton config. However, this global template is going to be merged with any templates you specify in your TaskRuns and PipelineRuns. Any field that is present in both the global template and the TaskRun's or PipelineRun's template will be taken from the TaskRun or PipelineRun.

@imjasonh
Copy link
Member

imjasonh commented Dec 7, 2021

Thanks!

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2021
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
@pritidesai
Copy link
Member

/test check-pr-has-kind-label

@imjasonh
Copy link
Member

/test pull-tekton-pipeline-alpha-integration-tests

@pritidesai
Copy link
Member

I am guessing its a flake but wondering why are we seeing this error:

stream.go:238: Invalid log format for pod tekton-pipelines-controller-85bcd8b8d5-sh6bk: {"level":"debug","ts":"2021-12-14T21:07:14.591Z","logger":"tekton-pipelines-controller","caller":"controller/controller.go:419","msg":"Adding to queue arendelle-llsp7/pipeline-task-timeout-rwwwhmvi (depth: 2)","commit":"5e4bf68","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler","knative.dev/kind":"tekton.dev.PipelineRun","knative.dev/key":"arendelle-llsp7/pipeline-task-timeout-rwwwhmvi"}

@pritidesai
Copy link
Member

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot merged commit b47e079 into tektoncd:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants