-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge default PodTemplate's affinity field #4406
Conversation
Currently, default PodTemplate's affinity field is ignored since `mergePodTemplateWithDefault` doesn't merge `affinity` field. Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
Hi @devholic. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Is there a docs update we need to make corresponding to this change? |
I think we don't have to update document since it is mentioned in Pod templates document 🙂
|
Thanks! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check-pr-has-kind-label |
/test pull-tekton-pipeline-alpha-integration-tests |
I am guessing its a flake but wondering why are we seeing this error:
|
/test pull-tekton-pipeline-alpha-integration-tests |
Changes
Currently, default PodTemplate's affinity field is ignored since
mergePodTemplateWithDefault
doesn't mergeaffinity
field.This PR will merge default PodTemplate's affinity field.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes